fix vulkan validation errors #342
korejanAnnotations
111 warnings
|
prettier
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actionsx/prettier@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
very complex type used. Consider factoring parts into `type` definitions:
alvr\server\src\lib.rs#L54
warning: very complex type used. Consider factoring parts into `type` definitions
--> alvr\server\src\lib.rs:54:30
|
54 | static ref VIDEO_SENDER: Mutex<Option<mpsc::UnboundedSender<(VideoFrameHeaderPacket, Vec<u8>)>>> =
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
|
field `version` is never read:
alvr\server\src\connection.rs#L88
warning: field `version` is never read
--> alvr\server\src\connection.rs:88:5
|
86 | struct ConnectionInfo {
| -------------- field in this struct
87 | client_ip: IpAddr,
88 | version: Option<Version>,
| ^^^^^^^
|
|
field `hostname` is never read:
alvr\server\src\connection.rs#L53
warning: field `hostname` is never read
--> alvr\server\src\connection.rs:53:5
|
52 | struct ClientId {
| -------- field in this struct
53 | hostname: String,
| ^^^^^^^^
|
= note: `ClientId` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
|
unused import: `prelude::*`:
alvr\server\src\lib.rs#L19
warning: unused import: `prelude::*`
--> alvr\server\src\lib.rs:19:37
|
19 | use alvr_common::{lazy_static, log, prelude::*, ALVR_VERSION};
| ^^^^^^^^^^
|
|
unused imports: `Mat4`, `log`:
alvr\server\src\connection.rs#L8
warning: unused imports: `Mat4`, `log`
--> alvr\server\src\connection.rs:8:12
|
8 | glam::{Mat4, Quat, Vec2, Vec3},
| ^^^^
9 | log,
| ^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
deref which would be done by auto-deref:
alvr\audio\src\lib.rs#L638
warning: deref which would be done by auto-deref
--> alvr\audio\src\lib.rs:638:17
|
638 | &mut *self.sample_buffer.lock(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut self.sample_buffer.lock()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `#[warn(clippy::explicit_auto_deref)]` on by default
|
|
field `stream_id` is never read:
alvr\sockets\src\stream_socket\mod.rs#L220
warning: field `stream_id` is never read
--> alvr\sockets\src\stream_socket\mod.rs:220:5
|
219 | pub struct StreamReceiver<T> {
| -------------- field in this struct
220 | stream_id: StreamId,
| ^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
the borrowed expression implements the required traits:
alvr\session\src\lib.rs#L617
warning: the borrowed expression implements the required traits
--> alvr\session\src\lib.rs:617:53
|
617 | let session_desc = match fs::read_to_string(&session_path) {
| ^^^^^^^^^^^^^ help: change this to: `session_path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
useless use of `vec!`:
alvr\xtask\src\main.rs#L1156
warning: useless use of `vec!`
--> alvr\xtask\src\main.rs:1156:36
|
1156 | let flavours = vec![
| ____________________________________^
1157 | | (for_generic, AndroidFlavor::Generic),
1158 | | (for_oculus_quest, AndroidFlavor::OculusQuest),
1159 | | (for_pico, AndroidFlavor::Pico),
1160 | | (for_pico_neo_v4, AndroidFlavor::PicoV4),
1161 | | (for_lynx, AndroidFlavor::Lynx),
1162 | | ];
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
= note: `#[warn(clippy::useless_vec)]` on by default
help: you can use an array directly
|
1156 ~ let flavours = [(for_generic, AndroidFlavor::Generic),
1157 + (for_oculus_quest, AndroidFlavor::OculusQuest),
1158 + (for_pico, AndroidFlavor::Pico),
1159 + (for_pico_neo_v4, AndroidFlavor::PicoV4),
1160 ~ (for_lynx, AndroidFlavor::Lynx)];
|
|
|
struct update has no effect, all the fields in the struct have already been specified:
alvr\xtask\src\main.rs#L1089
warning: struct update has no effect, all the fields in the struct have already been specified
--> alvr\xtask\src\main.rs:1089:27
|
1089 | ..Default::default()
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
= note: `#[warn(clippy::needless_update)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
alvr\xtask\src\main.rs#L967
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> alvr\xtask\src\main.rs:967:41
|
967 | .filter(|entry| is_package_file(&entry))
| ^^^^^^ help: change this to: `entry`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
unneeded `return` statement:
alvr\xtask\src\main.rs#L959
warning: unneeded `return` statement
--> alvr\xtask\src\main.rs:959:13
|
959 | return ["apk", "aar", "idsig"].contains(&ext_str);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
959 - return ["apk", "aar", "idsig"].contains(&ext_str);
959 + ["apk", "aar", "idsig"].contains(&ext_str)
|
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
alvr\xtask\src\main.rs#L839
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> alvr\xtask\src\main.rs:839:61
|
839 | let run_ait_cmd = |cmd: &str| command::run_in(&ait_dir, &cmd).unwrap();
| ^^^^ help: change this to: `cmd`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
manual implementation of an assign operation:
alvr\xtask\src\main.rs#L812
warning: manual implementation of an assign operation
--> alvr\xtask\src\main.rs:812:9
|
812 | archs = archs + "_debug";
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `archs += "_debug"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
= note: `#[warn(clippy::assign_op_pattern)]` on by default
|
|
the borrowed expression implements the required traits:
alvr\xtask\src\main.rs#L806
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:806:36
|
806 | alxr_client_build_dir.join(&cert),
| ^^^^^ help: change this to: `cert`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr\xtask\src\main.rs#L805
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:805:30
|
805 | alxr_client_dir.join(&cert),
| ^^^^^ help: change this to: `cert`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
redundant closure:
alvr\xtask\src\main.rs#L775
warning: redundant closure
--> alvr\xtask\src\main.rs:775:57
|
775 | for arch in [UWPArch::X86_64, UWPArch::Aarch64].map(|x| batch_arch_str(x)) {
| ^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `batch_arch_str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
|
|
the borrowed expression implements the required traits:
alvr\xtask\src\main.rs#L772
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:772:52
|
772 | let pack_map_path = alxr_client_build_dir.join(&pack_map_fname);
| ^^^^^^^^^^^^^^^ help: change this to: `pack_map_fname`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
alvr\xtask\src\main.rs#L768
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> alvr\xtask\src\main.rs:768:24
|
768 | .unwrap_or(&alxr_client_build_dir),
| ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `alxr_client_build_dir`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
alvr\xtask\src\main.rs#L749
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:749:32
|
749 | fs::copy(&src_packed_file, &dst_packed_file).unwrap();
| ^^^^^^^^^^^^^^^^ help: change this to: `dst_packed_file`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr\xtask\src\main.rs#L722
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:722:69
|
722 | let relative_path = linked_depend_file.strip_prefix(&linked_path).unwrap();
| ^^^^^^^^^^^^ help: change this to: `linked_path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
alvr\xtask\src\main.rs#L720
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> alvr\xtask\src\main.rs:720:56
|
720 | .filter(|entry| is_linked_depends_file(&entry))
| ^^^^^^ help: change this to: `entry`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
alvr\xtask\src\main.rs#L678
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> alvr\xtask\src\main.rs:678:36
|
678 | if afs::is_dynlib_file(&path) {
| ^^^^^ help: change this to: `path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
unneeded `return` statement:
alvr\xtask\src\main.rs#L698
warning: unneeded `return` statement
--> alvr\xtask\src\main.rs:698:13
|
698 | return false;
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
698 - return false;
698 + false
|
|
|
the borrowed expression implements the required traits:
alvr\xtask\src\main.rs#L607
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:607:40
|
607 | alxr_client_build_dir.join(&pdb_fname),
| ^^^^^^^^^^ help: change this to: `pdb_fname`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr\xtask\src\main.rs#L606
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:606:32
|
606 | artifacts_dir.join(&pdb_fname),
| ^^^^^^^^^^ help: change this to: `pdb_fname`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
alvr\xtask\src\main.rs#L594
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> alvr\xtask\src\main.rs:594:52
|
594 | .filter(|entry| is_linked_depends_file(&entry))
| ^^^^^^ help: change this to: `entry`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
alvr\xtask\src\main.rs#L563
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> alvr\xtask\src\main.rs:563:32
|
563 | if afs::is_dynlib_file(&path) {
| ^^^^^ help: change this to: `path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
unneeded `return` statement:
alvr\xtask\src\main.rs#L583
warning: unneeded `return` statement
--> alvr\xtask\src\main.rs:583:9
|
583 | return false;
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
583 - return false;
583 + false
|
|
|
the borrowed expression implements the required traits:
alvr\xtask\src\main.rs#L520
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:520:62
|
520 | if so_filename.to_string_lossy().starts_with(&key) {
| ^^^^ help: change this to: `key`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
alvr\xtask\src\main.rs#L517
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> alvr\xtask\src\main.rs:517:52
|
517 | .filter(|path| afs::is_dynlib_file(&path))
| ^^^^^ help: change this to: `path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
alvr\xtask\src\main.rs#L503
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> alvr\xtask\src\main.rs:503:13
|
503 | &ffmpeg_build_dir,
| ^^^^^^^^^^^^^^^^^ help: change this to: `ffmpeg_build_dir`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
length comparison to zero:
alvr\xtask\src\main.rs#L470
warning: length comparison to zero
--> alvr\xtask\src\main.rs:470:16
|
470 | if build_str.len() > 0 {
| ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!build_str.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
|
|
length comparison to zero:
alvr\xtask\src\main.rs#L469
warning: length comparison to zero
--> alvr\xtask\src\main.rs:469:12
|
469 | if features.len() > 0 {
| ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!features.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
|
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
alvr\xtask\src\main.rs#L457
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> alvr\xtask\src\main.rs:457:26
|
457 | fn to_str_vec(m: &Vec<(bool, &'static str)>) -> Vec<&'static str> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(bool, &'static str)]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|
|
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`:
alvr\xtask\src\main.rs#L402
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> alvr\xtask\src\main.rs:402:21
|
402 | / match lp.as_str().strip_prefix("native=") {
403 | | Some(p) => {
404 | | linked_path_set.insert(p.into());
405 | | }
406 | | None => (),
407 | | }
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
help: try
|
402 ~ if let Some(p) = lp.as_str().strip_prefix("native=") {
403 + linked_path_set.insert(p.into());
404 + }
|
|
|
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`:
alvr\xtask\src\main.rs#L399
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> alvr\xtask\src\main.rs:399:9
|
399 | / match message? {
400 | | Message::BuildScriptExecuted(script) => {
401 | | for lp in script.linked_paths.iter() {
402 | | match lp.as_str().strip_prefix("native=") {
... |
410 | | _ => (),
411 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
= note: `#[warn(clippy::single_match)]` on by default
help: try
|
399 ~ if let Message::BuildScriptExecuted(script) = message? {
400 + for lp in script.linked_paths.iter() {
401 + match lp.as_str().strip_prefix("native=") {
402 + Some(p) => {
403 + linked_path_set.insert(p.into());
404 + }
405 + None => (),
406 + }
407 + }
408 + }
|
|
|
the borrowed expression implements the required traits:
alvr\xtask\src\main.rs#L384
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:384:50
|
384 | let mut command = std::process::Command::new(&cmd);
| ^^^^ help: change this to: `cmd`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr\xtask\src\main.rs#L338
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:338:24
|
338 | fs::create_dir_all(&afs::build_dir().join(&artifact_name)).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `afs::build_dir().join(&artifact_name)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr\xtask\src\main.rs#L285
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:285:24
|
285 | fs::create_dir_all(&layout.dashboard_dir()).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `layout.dashboard_dir()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr\xtask\src\main.rs#L272
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:272:24
|
272 | fs::create_dir_all(&layout.resources_dir()).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `layout.resources_dir()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr\xtask\src\main.rs#L164
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:164:48
|
164 | fs::copy(lib.clone(), lib_dir.join(&lib_filename)).unwrap();
| ^^^^^^^^^^^^^ help: change this to: `lib_filename`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr\xtask\src\main.rs#L137
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:137:24
|
137 | fs::create_dir_all(&layout.launcher_exe().parent().unwrap()).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `layout.launcher_exe().parent().unwrap()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr\xtask\src\main.rs#L136
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:136:24
|
136 | fs::create_dir_all(&layout.openvr_driver_lib().parent().unwrap()).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `layout.openvr_driver_lib().parent().unwrap()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr\xtask\src\main.rs#L135
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:135:24
|
135 | fs::create_dir_all(&afs::server_build_dir()).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `afs::server_build_dir()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr\xtask\src\main.rs#L134
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:134:24
|
134 | fs::remove_dir_all(&afs::server_build_dir()).ok();
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `afs::server_build_dir()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
this function has too many arguments (8/7):
alvr\xtask\src\main.rs#L80
warning: this function has too many arguments (8/7)
--> alvr\xtask\src\main.rs:80:1
|
80 | / pub fn build_server(
81 | | is_release: bool,
82 | | experiments: bool,
83 | | fetch_crates: bool,
... |
88 | | reproducible: bool,
89 | | ) {
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
|
the borrowed expression implements the required traits:
alvr\xtask\src\main.rs#L77
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\main.rs:77:24
|
77 | fs::remove_dir_all(&build_dir).ok();
| ^^^^^^^^^^ help: change this to: `build_dir`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr\xtask\src\version.rs#L179
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\version.rs:179:28
|
179 | .map(|d| base_dir.join(&d).to_str().unwrap().to_owned())
| ^^ help: change this to: `d`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
`filter(..).map(..)` can be simplified as `filter_map(..)`:
alvr\xtask\src\dependencies.rs#L204
warning: `filter(..).map(..)` can be simplified as `filter_map(..)`
--> alvr\xtask\src\dependencies.rs:204:18
|
204 | .filter(|result| result.is_ok())
| __________________^
205 | | .map(|pp| pp.unwrap())
| |______________________________________^ help: try: `filter_map(|pp| pp.ok())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_filter_map
= note: `#[warn(clippy::manual_filter_map)]` on by default
|
|
the borrowed expression implements the required traits:
alvr\xtask\src\dependencies.rs#L196
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\dependencies.rs:196:15
|
196 | .args(&["-c", &cmdline])
| ^^^^^^^^^^^^^^^^^ help: change this to: `["-c", &cmdline]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
length comparison to zero:
alvr\xtask\src\dependencies.rs#L124
warning: length comparison to zero
--> alvr\xtask\src\dependencies.rs:124:8
|
124 | if install_prefix.len() > 0 {
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!install_prefix.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
|
|
length comparison to zero:
alvr\xtask\src\dependencies.rs#L52
warning: length comparison to zero
--> alvr\xtask\src\dependencies.rs:52:22
|
52 | Some(ips) if ips.len() > 0 => {
| ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!ips.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
= note: `#[warn(clippy::len_zero)]` on by default
|
|
single-character string constant used as pattern:
alvr\xtask\src\dependencies.rs#L30
warning: single-character string constant used as pattern
--> alvr\xtask\src\dependencies.rs:30:83
|
30 | let ffmpeg_path = download_path.join(format!("FFmpeg-{}", version_tag.replace("/", "-")));
| ^^^ help: try using a `char` instead: `'/'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
= note: `#[warn(clippy::single_char_pattern)]` on by default
|
|
the borrowed expression implements the required traits:
alvr\xtask\src\dependencies.rs#L13
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\dependencies.rs:13:24
|
13 | fs::create_dir_all(&destination).unwrap();
| ^^^^^^^^^^^^ help: change this to: `destination`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr\xtask\src\dependencies.rs#L12
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\dependencies.rs:12:24
|
12 | fs::remove_dir_all(&destination).ok();
| ^^^^^^^^^^^^ help: change this to: `destination`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
useless use of `format!`:
alvr\xtask\src\command.rs#L154
warning: useless use of `format!`
--> alvr\xtask\src\command.rs:154:31
|
154 | let result = Command::new(format!("cargo"))
| ^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"cargo".to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `#[warn(clippy::useless_format)]` on by default
|
|
used consecutive `str::replace` call:
alvr\xtask\src\command.rs#L149
warning: used consecutive `str::replace` call
--> alvr\xtask\src\command.rs:149:10
|
149 | .replace('\r', "")
| __________^
150 | | .replace('\n', "")
| |__________________________^ help: replace with: `replace(['\r', '\n'], "")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace
= note: `#[warn(clippy::collapsible_str_replace)]` on by default
|
|
the borrowed expression implements the required traits:
alvr\xtask\src\command.rs#L141
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\command.rs:141:19
|
141 | .args(&["-u", "+%Y.%m.%d"])
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-u", "+%Y.%m.%d"]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr\xtask\src\command.rs#L29
warning: the borrowed expression implements the required traits
--> alvr\xtask\src\command.rs:29:15
|
29 | .args(&[shell_flag, cmd])
| ^^^^^^^^^^^^^^^^^^ help: change this to: `[shell_flag, cmd]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
variable does not need to be mutable:
alvr\xtask\src\main.rs#L1048
warning: variable does not need to be mutable
--> alvr\xtask\src\main.rs:1048:13
|
1048 | let mut ffmpeg_version: String =
| ----^^^^^^^^^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
|
the borrowed expression implements the required traits:
alvr\launcher\src\commands.rs#L62
warning: the borrowed expression implements the required traits
--> alvr\launcher\src\commands.rs:62:15
|
62 | .args(&["/PID", &pid.to_string(), "/F"])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["/PID", &pid.to_string(), "/F"]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr\launcher\src\commands.rs#L52
warning: the borrowed expression implements the required traits
--> alvr\launcher\src\commands.rs:52:50
|
52 | spawn_no_window(Command::new("cmd").args(&["/C", "start", "steam://rungameid/250820"]));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["/C", "start", "steam://rungameid/250820"]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
unused import: `DictionaryDefault`:
alvr\session\src\settings.rs#L4
warning: unused import: `DictionaryDefault`
--> alvr\session\src\settings.rs:4:23
|
4 | use settings_schema::{DictionaryDefault, EntryData, SettingsSchema, Switch, SwitchDefault};
| ^^^^^^^^^^^^^^^^^
|
|
unused import: `alvr_common::ALVR_VERSION`:
alvr\session\src\settings.rs#L1
warning: unused import: `alvr_common::ALVR_VERSION`
--> alvr\session\src\settings.rs:1:5
|
1 | use alvr_common::ALVR_VERSION;
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1219
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1219:25
|
1219 | no_decoder: no_decoder,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_decoder`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1215
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1215:25
|
1215 | reproducible: reproducible,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reproducible`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1214
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1214:25
|
1214 | is_release: is_release,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_release`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1206
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1206:25
|
1206 | no_decoder: no_decoder,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_decoder`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1202
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1202:25
|
1202 | reproducible: reproducible,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reproducible`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1201
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1201:25
|
1201 | is_release: is_release,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_release`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1193
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1193:25
|
1193 | no_decoder: no_decoder,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_decoder`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1189
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1189:25
|
1189 | reproducible: reproducible,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reproducible`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1188
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1188:25
|
1188 | is_release: is_release,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_release`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1180
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1180:25
|
1180 | no_decoder: no_decoder,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_decoder`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1176
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1176:25
|
1176 | reproducible: reproducible,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reproducible`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1175
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1175:25
|
1175 | is_release: is_release,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_release`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1153
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1153:25
|
1153 | no_decoder: no_decoder,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_decoder`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1149
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1149:25
|
1149 | reproducible: reproducible,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reproducible`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1148
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1148:25
|
1148 | is_release: is_release,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_release`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1142
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1142:25
|
1142 | no_decoder: no_decoder,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_decoder`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1140
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1140:25
|
1140 | bundle_ffmpeg: bundle_ffmpeg,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bundle_ffmpeg`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1139
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1139:25
|
1139 | no_nvidia: no_nvidia,
| ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_nvidia`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1138
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1138:25
|
1138 | reproducible: reproducible,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reproducible`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1137
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1137:25
|
1137 | is_release: is_release,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_release`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1125
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1125:25
|
1125 | no_decoder: no_decoder,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_decoder`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1121
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1121:25
|
1121 | reproducible: reproducible,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reproducible`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1120
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1120:25
|
1120 | is_release: is_release,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_release`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1114
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1114:25
|
1114 | no_decoder: no_decoder,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_decoder`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1110
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1110:25
|
1110 | reproducible: reproducible,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reproducible`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1109
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1109:25
|
1109 | is_release: is_release,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_release`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1101
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1101:25
|
1101 | no_decoder: no_decoder,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_decoder`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1097
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1097:25
|
1097 | reproducible: reproducible,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reproducible`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1096
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1096:25
|
1096 | is_release: is_release,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_release`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1088
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1088:25
|
1088 | oculus_ext: oculus_ext,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `oculus_ext`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1087
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1087:25
|
1087 | no_decoder: no_decoder,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_decoder`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1085
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1085:25
|
1085 | bundle_ffmpeg: bundle_ffmpeg,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bundle_ffmpeg`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1084
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1084:25
|
1084 | no_nvidia: no_nvidia,
| ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `no_nvidia`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1083
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1083:25
|
1083 | reproducible: reproducible,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reproducible`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
|
|
redundant field names in struct initialization:
alvr\xtask\src\main.rs#L1082
warning: redundant field names in struct initialization
--> alvr\xtask\src\main.rs:1082:25
|
1082 | is_release: is_release,
| ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_release`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
= note: `#[warn(clippy::redundant_field_names)]` on by default
|
|
accessing first element with `from_openvr_paths(paths_json).get(0)`:
alvr\commands\src\openvrpaths.rs#L66
warning: accessing first element with `from_openvr_paths(paths_json).get(0)`
--> alvr\commands\src\openvrpaths.rs:66:17
|
66 | trace_none!(from_openvr_paths(paths_json).get(0).cloned())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `from_openvr_paths(paths_json).first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
= note: `#[warn(clippy::get_first)]` on by default
|
|
unneeded late initialization:
alvr\commands\src\firewall.rs#L20
warning: unneeded late initialization
--> alvr\commands\src\firewall.rs:20:5
|
20 | let exit_status;
| ^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
= note: `#[warn(clippy::needless_late_init)]` on by default
help: declare `exit_status` here
|
22 | let exit_status = if cfg!(target_os = "linux") {
| +++++++++++++++++
help: remove the assignments from the branches
|
25 ~ Command::new("bash")
26 | .arg("/usr/libexec/alvr/alvr_fw_config.sh")
27 | .arg(action)
28 | .status()
29 ~ .map_err(|_| -1)?
30 | } else {
...
61 | // run with admin privileges
62 ~ runas::Command::new(script_path)
63 | .gui(true) // UAC, if available
64 | .status()
65 ~ .map_err(|_| -1)?
|
help: add a semicolon after the `if` expression
|
66 | };
| +
|
|
unused import: `alvr_filesystem as afs`:
alvr\server\build.rs#L1
warning: unused import: `alvr_filesystem as afs`
--> alvr\server\build.rs:1:5
|
1 | use alvr_filesystem as afs;
| ^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
|
useless use of `format!`:
alvr\filesystem\src\lib.rs#L101
warning: useless use of `format!`
--> alvr\filesystem\src\lib.rs:101:27
|
101 | let alxr_client_dir = format!("alxr_client_uwp");
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"alxr_client_uwp".to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `#[warn(clippy::useless_format)]` on by default
|
|
unneeded `return` statement:
alvr\filesystem\src\lib.rs#L29
warning: unneeded `return` statement
--> alvr\filesystem\src\lib.rs:29:5
|
29 | return false;
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
29 - return false;
29 + false
|
|
|
useless use of `format!`:
alvr\filesystem\src\lib.rs#L101
warning: useless use of `format!`
--> alvr\filesystem\src\lib.rs:101:27
|
101 | let alxr_client_dir = format!("alxr_client_uwp");
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"alxr_client_uwp".to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `#[warn(clippy::useless_format)]` on by default
|
|
unneeded `return` statement:
alvr\filesystem\src\lib.rs#L29
warning: unneeded `return` statement
--> alvr\filesystem\src\lib.rs:29:5
|
29 | return false;
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
29 - return false;
29 + false
|
|
|
the borrowed expression implements the required traits:
alvr\settings-schema-derive\src\lib.rs#L406
warning: the borrowed expression implements the required traits
--> alvr\settings-schema-derive\src\lib.rs:406:40
|
406 | _ => error("Unsupported type", &ty),
| ^^^ help: change this to: `ty`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
alvr\settings-schema-derive\src\lib.rs#L403
warning: the borrowed expression implements the required traits
--> alvr\settings-schema-derive\src\lib.rs:403:78
|
403 | error("Generics are supported only for Option, Switch, Vec", &ty)
| ^^^ help: change this to: `ty`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
deref which would be done by auto-deref:
alvr\settings-schema-derive\src\lib.rs#L276
warning: deref which would be done by auto-deref
--> alvr\settings-schema-derive\src\lib.rs:276:29
|
276 | } = type_schema(&*ty_array.elem, schema_attrs)?;
| ^^^^^^^^^^^^^^^ help: try: `&ty_array.elem`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
= note: `#[warn(clippy::explicit_auto_deref)]` on by default
|