Fix regression bug in $elemMatch. closes #139

kofrasa · Apr 27, 2020 · b8505e7 · b8505e7
1 parent 8b4c13d
commit b8505e7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/init/index.ts b/src/init/index.ts
@@ -2,7 +2,7 @@
  * Loads all Query and Projection operators
  */
 import * as booleanOperators from '../operators/expression/boolean'
-import * as comparsonOperators from '../operators/expression/comparison'
+import * as comparisonOperators from '../operators/expression/comparison'
 import { $project, $skip, $limit, $sort } from '../operators/pipeline'
 import * as queryOperators from '../operators/query'
 import * as projectionOperators from '../operators/projection'
@@ -15,7 +15,7 @@ import { into } from '../util'
  * Enable default operators. This includes only query and projection operators
  */
 function enableDefaultOperators() {
-  useOperators(OperatorType.EXPRESSION, into({}, booleanOperators, comparsonOperators))
+  useOperators(OperatorType.EXPRESSION, into({}, booleanOperators, comparisonOperators))
   useOperators(OperatorType.PIPELINE, { $project, $skip, $limit, $sort })
   useOperators(OperatorType.PROJECTION, projectionOperators)
   useOperators(OperatorType.QUERY, queryOperators)

diff --git a/src/operators/_predicates.ts b/src/operators/_predicates.ts
@@ -11,6 +11,7 @@ import {
   isArray,
   isBoolean,
   isDate,
+  isEmpty,
   isEqual,
   isNil,
   isNull,
@@ -239,7 +240,8 @@ export function $size(a: any[], b: number): boolean {
  * @param b {Object} subquery
  */
 export function $elemMatch(a: any[], b: object): boolean {
-  if (a.length > 0) {
+  // should return false for non-matching input
+  if (isArray(a) && !isEmpty(a)) {
     let format = (x: any) => x
     let criteria = b