Reworked to catch broken promise chains #148
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address the issue outlined in #74 and the original ticket in the koa repo, I've refactored the recursion implementation to make it easier to keep track of whether or not next hasn't resolved.
The fundamental thing I've done is to add a proxy for the next middleware that will note when the next dispatch call returns. If any given middleware calls next and resolves before it does we throw an error. Additionally I've stripped out all of the safeguards in production to slim the implementation even more.
In production it won't be dissimilar to how things are already implemented. In development though, there will be an increase in memory footprint as, in addition to more variables, there will be an extra stack frame per middleware.