Fix: Record TOC navigations in history (#1248) #1348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jinash-Rouniyar Thank you for your PR. Please make commits only related and necessary to your change. I won't review 30.000 lines of code changes. |
Jinash-Rouniyar
force-pushed
the
feature/toc-history-#1248
branch
from
636fa42 to
a599475
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1248
Currently, TOC navigations do not go through the Qt system and use JavaScript to scroll directly.
This PR ensures that in-page history records those actions while still allowing JavaScript to handle scrolling.
This prevents unnecessary page refreshes that reset DOM states.
@kiwix/lieutenants Please review when available.