Exclude libgcc and libunwind from linked libraries on Android. #704
Conversation
As said in [1], unwinder is linked automatically by Clang and shared library must not re-export it. ndk after r23 (we are using r21) should be this. Else we must take care to not re-export it. From [2], we should pass the flags `Wl,--exclude-libs,libgcc.a` and `-Wl,--exclude-libs,libunwind.a` to avoid re-export `_Unwind_Resume` methods. Fix kiwix/kiwix-android#3661 [1] https://android.googlesource.com/platform/ndk/+/master/docs/BuildSystemMaintainers.md#Unwinding [2] android/ndk#889 (comment)
|
@mgautierfr I guess it fixes the unwind error, but not the crash scenario? |
|
@MohitMaliFtechiz, can you test with build libraries in https://tmp.kiwix.org/ci/dev_preview/fix_android_compilation please ?
The crash is due to the broken unwind. So it also fixes the crash. |
|
@mgautierfr, @kelson42 I have tested the test binary that you provided me and also with the https://tmp.kiwix.org/ci/dev_preview/fix_android_compilation, and the application is not crashing with these binary on the arm architecture. I can read the zim file without crashing. Also, the testZim is now starts showing on the library screen so the crash scenario is fixed for the arm architecture.
|
|
Perfect. I'm merging. |
As said in [1], unwinder is linked automatically by Clang and shared library must not re-export it.
ndk after r23 (we are using r21) should do this. Else we must take care to not re-export it.
From [2], we should pass the flags
Wl,--exclude-libs,libgcc.aand-Wl,--exclude-libs,libunwind.ato avoid re-export_Unwind_Resumemethods.Fix kiwix/kiwix-android#3661
[1] https://android.googlesource.com/platform/ndk/+/master/docs/BuildSystemMaintainers.md#Unwinding
[2] android/ndk#889 (comment)