-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed: Move canReadFile()
method to IO thread.
#4040
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moved the file readability check to the IO thread to prevent ANR. * Refactored the code to accommodate this change.
…ReaderWithSplittedZimFileTest.
* Improved the saving of bookmarks.
* Fixed the test cases.
…p modules due to a socket exception during the ZIM file download.
* The article URL was already available in the searchState, but we were redundantly retrieving the article URL from the pageTitle, resulting in an unnecessary extra call to libkiwix. To optimize this, we now directly use the URL provided by libkiwix for the searched item, reducing the extra call.
* Refactored some unnecessary code.
…er ZIM file was already opened in the reader. Instead of opening the bookmarked page, it always opens the home page of the current ZIM file.
… loaded page when we click on any searched item.
d4dae46
to
b834e62
Compare
…we open a new ZIM file in the reader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4039
The article URL was already available in the
searchState
, but we were redundantly retrieving the article URL from the pageTitle, resulting in an unnecessary extra call to libkiwix. To optimize this, we now directly use the URL provided by libkiwix for the searched item, reducing the additional call.