Removed Debouncing mechanism #3609
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introducing deprecated code check in CI
Fixes of Zim file does not download / pending forever
Improved the permission asking scenario for custom apps
… the notification
* Added pause/resume button beside the stop button to perform pause/resume action on the downloading zim file. * Handling pause/resume via fetch library.
Reintroduced Download pause/resume
…ady configured the storage in settings
Fixes of Storage configured dialog showing again in OnlineLibraryFragment if we configured it from settings's screen
…rage Scanning in play store variant
Updated README.md file to explain ZIM File Picker Restriction and Storage Scanning in play store variant
… any article is loading in the background. * When any article is loading then we invalidate the `OptionMenu` from `KiwixWebChromeClient` (It does not check whether the fragment is visible or not) which also invalidates the toolbar and the search bar is inside the toolbar that's the reason the keyboard showing and hiding repeatedly. * Now we are invalidating the `OptionMenu` inside the `CoreReaderFragment` when it is visible to the user since this fragment loads the content in the webview. Hence, it is better to update the UI when it is visible to the user so it would not affect any other UI part.
Fixed Keyboard repeatedly disappearing and reappearing in search when any article is loading in the background
Localisation updates from https://translatewiki.net.
* Added `tmpfs` filesystem to `support 4GB filesystem list` since this type supports writing files over 4GB. * Updated the name of the writing test result file to `kiwix_4gb_writing_test_result` to enhance readability.
Added tmpfs filesystem to `support 4GB filesystem` list and improved the writing test file name
… USB-OTG integration.
* Previously we can only open zim files from `USB-OTG` in android 10 and below devices, because `context.getExternalFilesDirs("")` does not provide the USB path in android 10 and above devices for security reasons. There is no direct way to access the USB-OTG on these devices, but USB-OTG are mounted under the `/mnt/media_rw` directory, so now we are directly using this to open zim files from USB drive for android 10 and above devices.
Fixed USB-OTG not working on android 11 and above devices
… it is not launching the activity and giving error `Could not launch intent Intent` this error comes when we have not `Display pop-up windows while running in the background` permission
Fixed Bookmark toggle is not ON for saved bookmarks
Localisation updates from https://translatewiki.net.
Fixed unable to open zim files on sd card in version 3.8.1
…t are copied to app-specific directory. * Scan the app-specific directory as well because we have limitations in scanning all directories on Android 11 and above in the Play Store variant. If a user copies the ZIM file to the app-specific directory on the SD card, the scanning of the app-specific directory on the SD card has not been added, resulting in the copied files not being displayed on the library screen. Therefore, we need to explicitly include the app-specific directory for scanning.
Fixed version `3.8.1` from Google Play cannot find zim on SD card that are copied to app-specific directory.
* If the custom app is configured to display the 'About the app' option in navigation, it will be visible. Clicking on it will redirect the user to the configured URL.
Fixed: Add Configuration Option for Custom Apps: "About" Link in Sidebar
Updated kiwix version to `3.9.0`.
Updated `CHANGELOG` for `3.9.0`.
… Store app to open sideloaded ZIM files. * Showing play store restriction to the users in the help screen in play store variant.
…tly open our official website for downloading the APK.
… the Play Store to the user.
…ix website for downloading the APK. This will make it easier for the user who wants to download the full APK version of the Kiwix app.
…ility. * Introduced test cases for the new functionality to ensure its expected behavior in both variants, such as Play Store and non-Play Store. * Updated other test cases to accommodate the testing of this new functionality.
Fixed Start-up message to inform about the restrictions on the Google Store app to open sideloaded ZIM files.
* The getEntryByPath method was being called twice when retrieving content. Consequently, the initial call returned the content entry URL with additional parameters. Subsequently, when making the second call with the provided URL, it resulted in an "entry not found" exception. This issue prevented the loading of the CSS and content of the Zim file. * Additionally, the getActualUrl method was primarily implemented to retrieve the redirect entry of the URL provided by the webView. It is unnecessary to invoke this method when obtaining content.
Fixed Zimit archives are not displaying correctly.
Localisation updates from https://translatewiki.net.
…he app" and "Support app." * Introduced the 'Support kiwix' option, which is configurable in the navigation for custom apps. If the custom app is set to display the "Support" menu item in navigation, it will be shown; otherwise, it will be hidden from the app. * Replaced the "kiwix" and "the" prefixes in "Support kiwix" and "About the app" with the app name in the navigation.
…e on Android 13 it takes time to find the views.
Fixed: Made a small improvement to the sidebar entries for "About the app" and "Support app."
Added a small change in the CHANGELOG for `3.9.0`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3608
It removes debounce mechanics in order to have a better user experince.
Screenshots