Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Heading): fix uppercase text transform in h5 and h6 #4625

Merged
merged 2 commits into from
Feb 18, 2025
Merged

fix(Heading): fix uppercase text transform in h5 and h6 #4625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
997885e
fix(Heading): fix uppercase text transform in h5 and h6
sarkaaa Feb 17, 2025
b3bc868
chore: update visual tests
sarkaaa Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...rc/Heading/Heading.ct.tsx-snapshots/visual-Heading-Heading-1-Desktop-darwin.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...src/Heading/Heading.ct.tsx-snapshots/visual-Heading-Heading-1-Desktop-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ding/Heading.ct.tsx-snapshots/visual-Heading-Heading-1-Large-Desktop-darwin.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ading/Heading.ct.tsx-snapshots/visual-Heading-Heading-1-Large-Desktop-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ading/Heading.ct.tsx-snapshots/visual-Heading-Heading-1-Large-Mobile-darwin.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...eading/Heading.ct.tsx-snapshots/visual-Heading-Heading-1-Large-Mobile-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ding/Heading.ct.tsx-snapshots/visual-Heading-Heading-1-Medium-Mobile-darwin.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ading/Heading.ct.tsx-snapshots/visual-Heading-Heading-1-Medium-Mobile-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ading/Heading.ct.tsx-snapshots/visual-Heading-Heading-1-Small-Mobile-darwin.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...eading/Heading.ct.tsx-snapshots/visual-Heading-Heading-1-Small-Mobile-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...src/Heading/Heading.ct.tsx-snapshots/visual-Heading-Heading-1-Tablet-darwin.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .../src/Heading/Heading.ct.tsx-snapshots/visual-Heading-Heading-1-Tablet-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
24 changes: 12 additions & 12 deletions packages/orbit-components/src/Heading/twClasses.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ export const typeClasses: {
[TYPE_OPTIONS.TITLE2]: "text-heading-title2 leading-heading-title2 font-heading-title2",
[TYPE_OPTIONS.TITLE3]: "text-heading-title3 leading-heading-title3 font-heading-title3",
[TYPE_OPTIONS.TITLE4]: "text-heading-title4 leading-heading-title4 font-heading-title4",
[TYPE_OPTIONS.TITLE5]: "text-heading-title5 leading-heading-title5 font-heading-title5 uppercase",
[TYPE_OPTIONS.TITLE6]: "text-heading-title6 leading-heading-title6 font-heading-title6",
[TYPE_OPTIONS.TITLE5]: "text-heading-title5 leading-heading-title5 font-heading-title5",
[TYPE_OPTIONS.TITLE6]: "text-heading-title6 leading-heading-title6 font-heading-title6 uppercase",
[QUERIES.MEDIUMMOBILE]: {
[TYPE_OPTIONS.DISPLAY]:
"mm:text-heading-display mm:leading-heading-display mm:font-heading-display",
Expand All @@ -30,9 +30,9 @@ export const typeClasses: {
[TYPE_OPTIONS.TITLE4]:
"mm:text-heading-title4 mm:leading-heading-title4 mm:font-heading-title4",
[TYPE_OPTIONS.TITLE5]:
"mm:text-heading-title5 mm:leading-heading-title5 mm:font-heading-title5 mm:uppercase",
"mm:text-heading-title5 mm:leading-heading-title5 mm:font-heading-title5",
[TYPE_OPTIONS.TITLE6]:
"mm:text-heading-title6 mm:leading-heading-title6 mm:font-heading-title6",
"mm:text-heading-title6 mm:leading-heading-title6 mm:font-heading-title6 mm:uppercase",
},
[QUERIES.LARGEMOBILE]: {
[TYPE_OPTIONS.DISPLAY]:
Expand All @@ -50,9 +50,9 @@ export const typeClasses: {
[TYPE_OPTIONS.TITLE4]:
"lm:text-heading-title4 lm:leading-heading-title4 lm:font-heading-title4",
[TYPE_OPTIONS.TITLE5]:
"lm:text-heading-title5 lm:leading-heading-title5 lm:font-heading-title5 lm:uppercase",
"lm:text-heading-title5 lm:leading-heading-title5 lm:font-heading-title5",
[TYPE_OPTIONS.TITLE6]:
"lm:text-heading-title6 lm:leading-heading-title6 lm:font-heading-title6",
"lm:text-heading-title6 lm:leading-heading-title6 lm:font-heading-title6 lm:uppercase",
},
[QUERIES.TABLET]: {
[TYPE_OPTIONS.DISPLAY]:
Expand All @@ -70,9 +70,9 @@ export const typeClasses: {
[TYPE_OPTIONS.TITLE4]:
"tb:text-heading-title4 tb:leading-heading-title4 tb:font-heading-title4",
[TYPE_OPTIONS.TITLE5]:
"tb:text-heading-title5 tb:leading-heading-title5 tb:font-heading-title5 tb:uppercase",
"tb:text-heading-title5 tb:leading-heading-title5 tb:font-heading-title5",
[TYPE_OPTIONS.TITLE6]:
"tb:text-heading-title6 tb:leading-heading-title6 tb:font-heading-title6",
"tb:text-heading-title6 tb:leading-heading-title6 tb:font-heading-title6 tb:uppercase",
},
[QUERIES.DESKTOP]: {
[TYPE_OPTIONS.DISPLAY]:
Expand All @@ -90,9 +90,9 @@ export const typeClasses: {
[TYPE_OPTIONS.TITLE4]:
"de:text-heading-title4 de:leading-heading-title4 de:font-heading-title4",
[TYPE_OPTIONS.TITLE5]:
"de:text-heading-title5 de:leading-heading-title5 de:font-heading-title5 de:uppercase",
"de:text-heading-title5 de:leading-heading-title5 de:font-heading-title5",
[TYPE_OPTIONS.TITLE6]:
"de:text-heading-title6 de:leading-heading-title6 de:font-heading-title6",
"de:text-heading-title6 de:leading-heading-title6 de:font-heading-title6 de:uppercase",
},
[QUERIES.LARGEDESKTOP]: {
[TYPE_OPTIONS.DISPLAY]:
Expand All @@ -110,8 +110,8 @@ export const typeClasses: {
[TYPE_OPTIONS.TITLE4]:
"ld:text-heading-title4 ld:leading-heading-title4 ld:font-heading-title4",
[TYPE_OPTIONS.TITLE5]:
"ld:text-heading-title5 ld:leading-heading-title5 ld:font-heading-title5 ld:uppercase",
"ld:text-heading-title5 ld:leading-heading-title5 ld:font-heading-title5",
[TYPE_OPTIONS.TITLE6]:
"ld:text-heading-title6 ld:leading-heading-title6 ld:font-heading-title6",
"ld:text-heading-title6 ld:leading-heading-title6 ld:font-heading-title6 ld:uppercase",
},
};