feat(Loading): improve accessibility of the Loading component #4616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying orbit with
|
| Latest commit: |
be8e356
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e674ba51.orbit.pages.dev |
| Branch Preview URL: | https://sarka-loading-a11y-fix.orbit.pages.dev |
|
Storybook staging is available at https://kiwicom-orbit-sarka-loading-a11y-fix.surge.sh Playroom staging is available at https://kiwicom-orbit-sarka-loading-a11y-fix.surge.sh/playroom |
|
Size Change: +68 B (+0.01%) Total Size: 461 kB
ℹ️ View Unchanged
|
sarkaaa
force-pushed
the
sarka/loading-a11y-fix
branch
7 times, most recently
from
7abfd35 to
a12a06b
Compare
sarkaaa
commented
Feb 17, 2025
sarkaaa
commented
Feb 17, 2025
sarkaaa
force-pushed
the
sarka/loading-a11y-fix
branch
2 times, most recently
from
f4f1aa4 to
3b71330
Compare
sarkaaa
changed the title
DSil
reviewed
Feb 19, 2025
docs/src/documentation/03-components/10-progress-indicators/loading/03-accessibility.mdx
Show resolved
Hide resolved
sarkaaa
force-pushed
the
sarka/loading-a11y-fix
branch
2 times, most recently
from
f53642e to
3ddb8f8
Compare
DSil
reviewed
Feb 19, 2025
sarkaaa
force-pushed
the
sarka/loading-a11y-fix
branch
from
3ddb8f8 to
29eb524
Compare
![callstackai[bot]](/~https://avatars.githubusercontent.com/in/1040204?s=60&v=4){kind=small}
I added some of them to check the rendered element or existency of the |
DSil
reviewed
Feb 19, 2025
DSil
reviewed
Feb 19, 2025
DSil
reviewed
Feb 19, 2025
sarkaaa
force-pushed
the
sarka/loading-a11y-fix
branch
from
90d8c4e to
76107e4
Compare
sarkaaa
force-pushed
the
sarka/loading-a11y-fix
branch
from
76107e4 to
be8e356
Compare
DSil
approved these changes
Feb 19, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request meets the following criteria:
For new components:
d.tsfiles and are exported inindex.d.ts✨
Description by Callstackai
This PR improves the accessibility of the Loading component by adding new props and enhancing its functionality.
Diagrams of code changes
sequenceDiagram participant App participant Loading participant Loader participant ScreenReader App->>Loading: Render Loading Component Note over Loading: Check if text prop exists alt Has text prop Loading->>Loading: Force div element else No text prop Loading->>Loading: Use asComponent prop (default: div) end Loading->>Loader: Render with title & type Loader->>Loader: Create SVG with role="img" Loader->>Loader: Add title element alt Screen Reader Active Loader->>ScreenReader: Announce title content end Loading-->>App: Return Rendered ComponentFiles Changed
This PR includes files in programming languages that we currently do not support. We have not reviewed files with the extensions
.mdx,.md. See list of supported languages.