Make changes for android.py file #691
Conversation
| @@ -798,9 +798,22 @@ def build_package(self): | |||
| pass | |||
|
|
|||
| # XXX found how the apk name is really built from the title | |||
| #gradle_files = ["build.gradle", "gradle", "gradlew"] | |||
There was a problem hiding this comment.
Thanks for the pull request.
Why commenting this rather than just deleting?
| #is_gradle_build = any(( | ||
| # exists(join(dist_dir, x)) for x in gradle_files)) | ||
| #if is_gradle_build: | ||
| __sdk_dir = self.android_sdk_dir |
There was a problem hiding this comment.
Why creating a local __sdk_dir variable if it's used just once?
Also why is this double underscore syntax for a local variable?
|
|
||
|
|
||
|
|
||
| # gradle_files = ["build.gradle", "gradle", "gradlew"] |
There was a problem hiding this comment.
Why commenting this? If we don't need it then let's just drop it
|
Hi @gautam-kumar-22 , thank you for taking a look and tackling this! I've started reviewing and left few comments. |
|
This PR cannot be merged, and comment important part necessary for gradle. If you still hit the issue, please rewrite it in a way it doesn't impact others stuff :) |
Fix the issue of copy apk file.