Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update seurat5 count matrix access #53

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chilampoon
Copy link

updated seurat5 count matrix access. After some testing, it's working well with the basic examples from the vignette.

@rrydbirk
Copy link
Collaborator

@evanbiederstedt @kdragicevic - looks fine to me. Merge?

@VPetukhov
Copy link
Contributor

Thank you for the update!

The old code uses a lot of @, which relies on specific Seurat versions and isn't recommended according to Seurat documentation. I wasn't aware of that when I wrote it, but now to make the code more stable we should avoid using @. I suggest rewriting data access as object[['RNA']]$counts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants