Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create icons for the tabs and link them with the code #38

Merged
merged 3 commits into from
Jan 23, 2019
Merged

Create icons for the tabs and link them with the code #38

merged 3 commits into from
Jan 23, 2019

Conversation

felixfoertsch
Copy link
Contributor

@felixfoertsch felixfoertsch commented Jan 17, 2019

@kgellci I added some dummy icons to the tab bar.

@kgellci
Copy link
Owner

kgellci commented Jan 19, 2019

@felixfoertsch Can you take a screenshot of the icons in place and paste into the description?

@felixfoertsch
Copy link
Contributor Author

@kgellci Where exactly do you mean by "into the description"? Here?

@kgellci
Copy link
Owner

kgellci commented Jan 19, 2019

@felixfoertsch You can edit your original comment at the top or add a new comment and drag a screenshot into it, similar to this one:

simulator screen shot - iphone xr - 2019-01-19 at 13 40 42

@felixfoertsch
Copy link
Contributor Author

tabbar icons

@kgellci This is how the icons look. I pushed a fix for CI. Let's see if it worked.

@kgellci kgellci merged commit fec75ca into kgellci:master Jan 23, 2019
@felixfoertsch felixfoertsch deleted the bugfix/tabbar-icons branch January 23, 2019 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants