Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ethi] Update Ethiopic kbds for language tagging #3233

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

LornaSIL
Copy link
Contributor

@LornaSIL LornaSIL commented Dec 3, 2024

Addresses some kbds in #3221

sil_ethiopic.kpj
sil_ethiopic_power_g.kpj
gff_ethiopic.kpj
gff_harege_fidelat.kpj
gff_mesobe_fidelat.kpj

Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dyacob do you want to review as well?

@LornaSIL
Copy link
Contributor Author

LornaSIL commented Dec 5, 2024

@dyacob is happy.

@LornaSIL LornaSIL merged commit 20ff629 into keymanapp:master Dec 5, 2024
2 checks passed
@LornaSIL LornaSIL deleted the ethi branch December 5, 2024 15:18
@dyacob
Copy link
Contributor

dyacob commented Dec 5, 2024

Yes, the changes look great -thanks for asking 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants