Add OIDC audience resolve protocol mapper

[thyming]

Closes #338.

[mrparkers]

LGTM besides the commented out code, I'd like to get that taken care of before we merge.

[thyming]

Deleted that commented code out.
Is there a way to generate docs or do I need to write those up by hand?

[mrparkers]

The docs are written by hand. I can write them if you don't want to.

Was there a particular issue that was preventing the update function from working? I'd prefer for this protocol mapper to support update like all of the other ones do.

[thyming]

Oh, just that there’s nothing to update - no config, name forces replacement, everything else is static.

…

On Wed, Oct 6, 2021 at 10:36 AM Michael Parker ***@***.***> wrote: The docs are written by hand. I can write them if you don't want to. Was there a particular issue that was preventing the update function from working? I'd prefer for this protocol mapper to support update like all of the other ones do. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#606 (comment)>, or unsubscribe </~https://github.com/notifications/unsubscribe-auth/AAQ5N2LKLK7AO23CY4SR6YTUFR3HTANCNFSM5FJY24WQ> .

[mrparkers]

Ah, I see that now, thanks for clarifying. With that new (helpful) information, I have a couple of comments.

[mrparkers]

I think it should be up to the user to specify the name for this mapper, so it should be part of the schema instead of hardcoded to "audience resolve".

I realize that this isn't super importan, because 1) it isn't editable on the Keycloak side (which I just learned today 😄) and 2) there's no reason to attach two different audience resolve protocol mappers to the same client / client scope.

However, since Keycloak allows you to create two instances of this protocol mapper attached to the same client with different names, this provider should allow it too.

[thyming]

Okey doke, updated to have that behavior.

[thyming]

@mrparkers I believe I addressed all your feedback. I also added a docs page - not sure if anything else needs to happen for that to be put in the index on the docs site.

[mrparkers]

This looks great, thanks for making those changes.

For the docs, they're automatically synced with registry.terraform.io when a release is cut. I'll be cutting a release hopefully today once some other PRs get merged.