Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exhaustive argument to group_roles #501

Merged
merged 3 commits into from
Apr 9, 2021
Merged

Add exhaustive argument to group_roles #501

merged 3 commits into from
Apr 9, 2021

Conversation

yesteph
Copy link
Contributor

@yesteph yesteph commented Mar 24, 2021

@yesteph yesteph force-pushed the non_auth_keycloak_group_roles branch from 3c6ddbd to 21d290a Compare March 24, 2021 16:45
mrparkers
mrparkers reviewed Mar 25, 2021
View reviewed changes
Copy link
Contributor

@mrparkers mrparkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just had one comment. I'd be happy to merge another PR that takes this approach for the keycloak_user_roles resource as well.

provider/resource_keycloak_group_roles.go Outdated Show resolved Hide resolved
This was referenced Mar 29, 2021
Closed
Merged
@yesteph yesteph force-pushed the non_auth_keycloak_group_roles branch from 9483486 to cf486bb Compare March 31, 2021 10:54
@yesteph yesteph force-pushed the non_auth_keycloak_group_roles branch from cf486bb to e1a0872 Compare April 2, 2021 08:31
@yesteph
Copy link
Contributor Author

yesteph commented Apr 2, 2021

@mrparkers : hi, the tests on 11.0.3 failed on features related to OpenID client optional scopes.
My changes do not (should) not modify this.

Please tell me what I can do to help ; for now I do not know.

mrparkers
mrparkers approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@mrparkers mrparkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the test failure was just a random error on the keycloak end. LGTM, thanks for the PR!

@mrparkers mrparkers merged commit 302f59c into keycloak:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StatueFungus StatueFungus StatueFungus left review comments

@mrparkers mrparkers mrparkers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yesteph @mrparkers @StatueFungus