Remove pad_with_end_token
argument in CLIPTokenizer
.
#2051
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2018
I have verified that
CLIPTokenizer
should always useend_token_id
aspad_token_id
in both CLIP and SD3.I’m not sure why I initially implemented
pad_with_end_token
arg. It might be related to how the internal SD3 code was implemented.CLIPPreprocessor
is still needed for both CLIP and SD3. When I implemented it, I didn’t have a clear idea about adding a task class for CLIP.@mattdangerw @divyashreepathihalli WDYT?
The script to verify the outputs: