Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🐛 Bug]: Some issues with facets in Incidents page #3069

Open
talboren opened this issue Jan 21, 2025 · 3 comments · Fixed by #3072
Open

[🐛 Bug]: Some issues with facets in Incidents page #3069

talboren opened this issue Jan 21, 2025 · 3 comments · Fixed by #3072
Assignees
@skynetigor
Labels
Bug Something isn't working

Comments

@talboren
Copy link
Member

talboren commented Jan 21, 2025 •
edited
Loading

After introduction of facets on Incidents page, there are a few small issues:

  • Empty state looks weird.
  • You can add facets with no name, which looks weird and may be confusing
  • Empty assignee should be better described
  • Default filter should not show deleted/resolved incidents (?)

Image
@dosubot dosubot bot added the Bug Something isn't working label Jan 21, 2025
@talboren
Copy link
Member Author

Image

@Matvey-Kuk
Copy link
Contributor

Super minor but the error widget jumped to the top-right. Usually it's in the middle of th epage (besides navigation). Image

@skynetigor skynetigor mentioned this issue Jan 21, 2025
Merged
4 tasks
@talboren
Copy link
Member Author

@skynetigor FYI there is still these issues appearing:

  1. page still looks quite strange when no incidents available
  2. there's the "create incident" button even when API is not on
CleanShot.2025-01-22.at.18.51.45.mp4

idk if it's related but just putting it here :)

@talboren talboren reopened this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skynetigor skynetigor

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui,be): minor bugs on Incidents after facets keephq/keep
3 participants
@Matvey-Kuk @skynetigor @talboren