Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Rename ClusterWorkspace #2569

Merged
merged 1 commit into from
Jan 9, 2023
Merged

🌱 Rename ClusterWorkspace #2569

merged 1 commit into from
Jan 9, 2023

Conversation

vincepri
Copy link
Contributor

@vincepri vincepri commented Jan 9, 2023

Signed-off-by: Vince Prignano vince@prigna.com

Summary

Starts renaming instances of ClusterWorkspace to Workspace in most cases

Related issue(s)

Related to #2510

@openshift-ci openshift-ci bot requested review from csams and davidfestal January 9, 2023 18:51
@openshift-ci openshift-ci bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jan 9, 2023
vincepri
vincepri commented Jan 9, 2023
View reviewed changes
pkg/server/options/authentication.go
@@ -43,7 +43,7 @@ const (
// A shard admin being member of the privileged system group.
// This will bypass most kcp authorization checks.
shardAdminUserName = "shard-admin"
// A kcp admin being member of system:kcp:clusterworkspace:admin and system:kcp:clusterworkspace:access.
// A kcp admin being member of system:kcp:workspace:admin and system:kcp:workspace:access.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found system:kcp:workspace:access but haven't found the admin one, is this comment up to date?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC those should be removed in favor of the new authorizers - let's open a follow-up issue and ask @s-urbaniak to clarify?

@vincepri
Copy link
Contributor Author

vincepri commented Jan 9, 2023

@sttts Should

kcp/pkg/authorization/bootstrap/policy.go

Lines 74 to 77 in 16e5542

Rules: []rbacv1.PolicyRule{
rbacv1helpers.NewRule("*").Groups(core.GroupName).Resources("logicalclusters", "logicalclusters/status").RuleOrDie(),
rbacv1helpers.NewRule("delete", "update", "get").Groups(tenancy.GroupName).Resources("clusterworkspaces", "workspaces").RuleOrDie(),
},
be renamed as well?

stevekuznetsov
stevekuznetsov approved these changes Jan 9, 2023
View reviewed changes
pkg/server/options/authentication.go
@@ -43,7 +43,7 @@ const (
// A shard admin being member of the privileged system group.
// This will bypass most kcp authorization checks.
shardAdminUserName = "shard-admin"
// A kcp admin being member of system:kcp:clusterworkspace:admin and system:kcp:clusterworkspace:access.
// A kcp admin being member of system:kcp:workspace:admin and system:kcp:workspace:access.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC those should be removed in favor of the new authorizers - let's open a follow-up issue and ask @s-urbaniak to clarify?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2023
@stevekuznetsov stevekuznetsov mentioned this pull request Jan 9, 2023
Closed
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2023
@stevekuznetsov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2023
@sttts
Copy link
Member

sttts commented Jan 9, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Jan 9, 2023
@sttts
Copy link
Member

sttts commented Jan 9, 2023

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jan 9, 2023
@vincepri
Rename ClusterWorkspace
c7f0e68 
Signed-off-by: Vince Prignano <vince@prigna.com>
@stevekuznetsov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2023
@openshift-merge-robot openshift-merge-robot merged commit c105220 into kcp-dev:main Jan 9, 2023
@lionelvillard lionelvillard mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov approved these changes

@csams csams Awaiting requested review from csams

@davidfestal davidfestal Awaiting requested review from davidfestal

Assignees

@sttts sttts

@stevekuznetsov stevekuznetsov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vincepri @stevekuznetsov @sttts @openshift-merge-robot