-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for headless Chrome/ChromeCanary #111
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -53,3 +53,20 @@ describe('canaryGetOptions', function () { | |
]) | ||
}) | ||
}) | ||
|
||
describe('headlessGetOptions', function () { | ||
var headlessGetOptions = launcher.test.headlessGetOptions | ||
|
||
it('should return the headless flags', function () { | ||
var parent = sinon.stub().returns(['-incognito']) | ||
var context = {} | ||
var url = 'http://localhost:9876' | ||
var args = {} | ||
expect(headlessGetOptions.call(context, url, args, parent)).to.be.eql([ | ||
'-incognito', | ||
'--headless', | ||
'--disable-gpu', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Curiosity: What are the pros of using incognito and disable-gpu? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
'--remote-debugging-port=9222' | ||
]) | ||
}) | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is out of date, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, yes it is (although it is also out-of-date further up in the file where I copied this block from)