additionInfo config object for Auxiliary network devices #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support for additionInfo config object for Auxiliary network devices to provide addtional information to sf's created for Mellanox BlueField-2 Fixes k8snetworkplumbingwg#627
to provide addtional information to sf's created for Mellanox BlueField-2 Fixes k8snetworkplumbingwg#627
to provide addtional information to sf's created for Mellanox BlueField-2
Added UT for additionInfo fields
Fixes k8snetworkplumbingwg#627
Pull Request Test Coverage Report for Build 13287834864Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
@adrianchiris do you think this pr can be merged as separate ut is added? |
|
@zeeke Can you please review the PR |
|
what could be done for build-test-lint / SR-IOV operator e2e tests (pull_request) test failures? |
Fixing here then we can see the result of the end2end tests |
is this fixed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support for additionInfo config object for Auxiliary network devices to provide addtional information to sf's created for Mellanox BlueField-2
Fixes #627