Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump base image of k3d-proxy to resolve vulnerabilities. #1473

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

jackson-chris
Copy link
Contributor

What

Bumps the base image of the k3d-proxy image to resolve various os package vulnerabilities.

Why

Resolves all vulnerabilities mentioned in #1472

Implications

I was unable to test this locally as of yet on my local machine to validate whether or not it causes any issues, will keep trying and update the ticket once I have validation (debugging local go installation issues with running the make files for this repo). If someone can validate easily and comment on ticket it would be appreciated.

@iwilltry42
Copy link
Member

Thanks for the PR @jackson-chris !
I'll merge it right away and it will land in the next patch release 👍

@louisnow
Copy link

louisnow commented Aug 6, 2024

Can we merge this in please?

@iwilltry42 iwilltry42 merged commit ef937a0 into k3d-io:main Aug 6, 2024
@reneleonhardt
Copy link

reneleonhardt commented Sep 12, 2024

nginx:1.26.1-alpine3.19 is nearly 3 months old.
nginx:1.26.2-alpine3.20 is the current stable:
https://nginx.org/en/download.html
https://hub.docker.com/_/nginx

Why aren't you using Dependabot or Renovate to stay up-to-date and apply security fixes in time?

@iwilltry42
Copy link
Member

iwilltry42 commented Sep 12, 2024

@reneleonhardt k3d is a development tool not focusing on running critical or production workloads, so there was never a focus around keeping everything up-to-date as fast as possible.

FWIW, Dependabot is active and proposing go module updates, but nothing else so far.
Feel free to open a PR to configure Dependabot or Renovate to catch all updates - I'll happily merge anything automating some work here 👍
Then we need to make sure that there are automatic releases once critical vulnerabilities have been patched.

UPDATE: I just added a basic renovate.json config to the repo and enabled Mend Renovate for k3d-io

@reneleonhardt
Copy link

Hello @iwilltry42 thank you for introducing renovate!
For automatic security releases please have a look at /~https://github.com/aquasecurity/trivy-action but unfortunately I can't find examples for your understandable DevSecOps use case 😅
Daily workflow: If latest commit contains fewer critical vulnerabilities than the latest release, build and publish a new patch release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants