-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support steps[*].defer:
steps.<key>.defer:
for deferring steps in a runbook
#1119
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…the store with the `previous` key.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
defer:
for deferring steps in a runbooksteps[*].defer:
steps.<key>.defer:
for deferring steps in a runbook
…o map. This will allow for easier handling of defer. ref: #1119
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
BenchmarkManyRunbooks-4
Metadata
BenchmarkOpenAPI3-4
Metadata
BenchmarkSingleRunbook-4
Metadata
Reported by octocov |
Code Metrics Report
Details | | main (e1b024f) | #1119 (c15d75b) | +/- |
|---------------------|----------------|-----------------|-------|
+ | Coverage | 64.5% | 64.6% | +0.0% |
| Files | 77 | 77 | 0 |
| Lines | 8958 | 9003 | +45 |
+ | Covered | 5783 | 5821 | +38 |
+ | Code to Test Ratio | 1:0.7 | 1:0.7 | +0.0 |
| Code | 16403 | 16487 | +84 |
+ | Test | 12498 | 12586 | +88 |
+ | Test Execution Time | 6m39s | 6m11s | -28s | Code coverage of files in pull request scope (74.1% → 74.2%)
Reported by octocov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to dockhood it and check it out.
I have a feeling that there will be some elements I would like to add to stores
with the addition of the defer
.
I have a feeling that there will be cases where I will want to evaluate steps that are already stacked in the LIFO of the defer.
There may be cases where an event that requires post-processing occurs several times, but the actual post-processing only needs to be done once.
desc: step 1 | ||
test: len(steps) == 0 | ||
- | ||
defer: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the defer section support formula expansion?
I haven't come up with a use case that is dynamic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the defer section support formula expansion?
No
Line 703 in e647346
st.deferred, ok = v.(bool) |
I haven't come up with a use case that is dynamic.
Me too 👍
Support
defer:
for deferring steps in a runbook.