-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check types with AssertEqual/AssertNotEqual #111
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this (and #107) get accepted, this needs to be hidden from the stacktrace also:
The easy way would be to rename the function to |
Would fix #115. |
Thanks, can you update the failing test case ( |
This is meant to make the error when comparing a list with something else more meaningful, where you currently get the following only: > Vim(if):E691: Can only compare List with List Fixes junegunn#115. Closes junegunn#116.
Done. Env vars are strings always. |
Thanks! |
hupfdule
pushed a commit
to hupfdule/vader.vim
that referenced
this pull request
May 6, 2020
This is meant to make the error when comparing a list with something else more meaningful, where you currently get the following only: > Vim(if):E691: Can only compare List with List Fixes junegunn#115. Closes junegunn#116.
hupfdule
pushed a commit
to hupfdule/vader.vim
that referenced
this pull request
May 28, 2020
This is meant to make the error when comparing a list with something else more meaningful, where you currently get the following only: > Vim(if):E691: Can only compare List with List Fixes junegunn#115. Closes junegunn#116.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be done only for incompatible types maybe (i.e. when
comparing list/dict with something else).
This is meant to make the error when comparing a list with something
else more meaningful, where you currently get the following only: