Merge pull request nsqio#950 from 1050676515/master

nsqlookupd: minor optimizations
judwhite · Oct 19, 2017 · 220ca47 · 220ca47
2 parents da81dd2 + d07707b
commit 220ca47
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/nsqlookupd/registration_db.go b/nsqlookupd/registration_db.go
@@ -76,6 +76,7 @@ func (r *RegistrationDB) AddProducer(k Registration, p *Producer) bool {
 	for _, producer := range producers {
 		if producer.peerInfo.id == p.peerInfo.id {
 			found = true
+			break
 		}
 	}
 	if found == false {

diff --git a/nsqlookupd/tcp.go b/nsqlookupd/tcp.go
@@ -21,6 +21,7 @@ func (p *tcpServer) Handle(clientConn net.Conn) {
 	_, err := io.ReadFull(clientConn, buf)
 	if err != nil {
 		p.ctx.nsqlookupd.logf(LOG_ERROR, "failed to read protocol version - %s", err)
+		clientConn.Close()
 		return
 	}
 	protocolMagic := string(buf)