Add a custom_color config option #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtheoof
force-pushed
the
master
branch
2 times, most recently
from
1c3eaa2 to
3083bb7
Compare
|
Bump @jtheoof |
|
A bit of late review ;) Please rebase and look at: /~https://github.com/jtheoof/swappy?tab=readme-ov-file#contributing |
DriesOlbrechts
force-pushed
the
master
branch
from
a9d5830 to
4e67067
Compare
DriesOlbrechts
force-pushed
the
master
branch
from
4e67067 to
d98975c
Compare
|
@jtheoof No worries, still using the tool years later 😄 Rebased and changed my commit message! |
|
Thanks for your contribution. |
jtheoof
reviewed
Oct 31, 2024
| @@ -79,6 +80,7 @@ The following lines can be used as swappy's default: | |||
| - *early_exit* is used to make the application exit after saving the picture or copying it to the clipboard | |||
| - *fill_shape* is used to toggle shape filling (for the rectangle and ellipsis tools) on or off upon startup | |||
| - *auto_save* is used to toggle auto saving of final buffer to *save_dir* upon exit | |||
| - *custom_color* is used to set a default value for the custom color | |||
There was a problem hiding this comment.
@DriesOlbrechts do you think you could add a bit more to the man page? Kind of repeating what format is supported as you did in the description of the MR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a config option to set the default color for the custom color option.
This way, if you often use the same color, you can set it as a config option.
It uses the gdk function
gdk_rgba_parsewhich supportshex, rgb(),rgba()aswell as a standard name.Docs:
As for the changes in
application.c. I was not sure where I should put the code to initialize this color.If you can tell me where it should go I will change it.