Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefab values for other java.time classes #218

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Add prefab values for other java.time classes #218

merged 1 commit into from
Oct 31, 2018

Conversation

eggilbert
Copy link
Contributor

What problem does this pull request solve?

#217

Please provide any additional information below.

This adds prefabricated values for the remaining java.time classes, except Clock, to fix Java 9+ illegal access warnings. I wasn't really sure what to do with Clock, as it's abstract and all the subclasses in the JDK are package-private. It doesn't seem like it would be used in the same way as the rest of these.

@jqno jqno merged commit 7769499 into jqno:master Oct 31, 2018
@jqno
Copy link
Owner

jqno commented Oct 31, 2018

Thanks, that was fast! :)
I like how you moved all date-time related classes into a separate method.

@eggilbert eggilbert deleted the gh-217 branch October 31, 2018 11:52
akhalikov pushed a commit to akhalikov/equalsverifier that referenced this pull request Nov 6, 2019
Add prefab values for other java.time classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants