Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump com.fasterxml.jackson:jackson-base from 2.16.2 to 2.18.2 #173

Merged
merged 22 commits into from
Jan 18, 2025
Merged

Bump com.fasterxml.jackson:jackson-base from 2.16.2 to 2.18.2 #173

merged 22 commits into from
Jan 18, 2025

Conversation

thetric
Copy link

@thetric thetric commented Dec 17, 2024 •
edited by joschi
Loading

Closes #167
Closes #172
Fixes #166

@thetric
Copy link
Author

thetric commented Dec 23, 2024

One test class to go 🥳

thetric
thetric commented Dec 27, 2024
View reviewed changes
pom.xml Show resolved Hide resolved
joschi
joschi reviewed Dec 27, 2024
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@thetric
Copy link
Author

thetric commented Jan 5, 2025

Ah, I now understand why the tests failed. Upstream has introduced a new Jackson module JavaTimeModule as a replacement for JSR310Module which configures some settings slightly different. Additionally, there is now an old package for the deprecated JSR310Module

@thetric thetric marked this pull request as ready for review January 5, 2025 17:07
thetric
thetric commented Jan 5, 2025
View reviewed changes
src/main/java/com/fasterxml/jackson/datatype/threetenbp/ThreeTenModule.java
public final class ThreeTenModule extends SimpleModule
{
@Deprecated // since 2.18
public final class ThreeTenModule extends SimpleModule {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated in favor of ThreeTenTimeModule

@thetric
Copy link
Author

thetric commented Jan 8, 2025

Hm, this seems to be an issue with Java 8. The other versions just work fine?

@joschi
Copy link
Owner

joschi commented Jan 9, 2025

Hm, this seems to be an issue with Java 8. The other versions just work fine?

Any idea what's causing the difference? The purpose of this library is supporting older Java versions, after all.

@thetric
Copy link
Author

thetric commented Jan 18, 2025

Ah, got it. The test was checking a bug present only in Java 8's implementation of java.time, which was fixed in ThreeTen some time ago so we can safely disable the test

@joschi joschi added enhancement dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jan 18, 2025
joschi
joschi approved these changes Jan 18, 2025
View reviewed changes
Copy link
Owner

@joschi joschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thetric Thanks a lot for your contribution! ❤️

@joschi joschi changed the title Update to Jackson 2.18.2 Bump com.fasterxml.jackson:jackson-base from 2.16.2 to 2.18.2 Jan 18, 2025
@joschi joschi merged commit 9ca05cf into joschi:master Jan 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joschi joschi joschi approved these changes

Assignees

@joschi joschi

@thetric thetric

Labels
dependencies Pull requests that update a dependency file enhancement java Pull requests that update Java code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create new release
3 participants
@thetric @joschi @vzorge