Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Add extra inlining to speed up take #226

Merged
merged 6 commits into from
Jul 25, 2021
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/buffer/mutable.rs
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,7 @@ impl<T: NativeType> MutableBuffer<T> {
/// # Safety
/// This method assumes that the iterator's size is correct and is undefined behavior
/// to use it on an iterator that reports an incorrect length.
#[inline]
Dandandan marked this conversation as resolved.
Show resolved Hide resolved
pub unsafe fn extend_from_trusted_len_iter_unchecked<I: Iterator<Item = T>>(
&mut self,
iterator: I,
Expand Down Expand Up @@ -461,6 +462,7 @@ impl<T: NativeType> MutableBuffer<T> {
/// # Safety
/// This method assumes that the iterator's size is correct and is undefined behavior
/// to use it on an iterator that reports an incorrect length.
#[inline]
Dandandan marked this conversation as resolved.
Show resolved Hide resolved
pub unsafe fn try_from_trusted_len_iter_unchecked<
E,
I: Iterator<Item = std::result::Result<T, E>>,
Expand Down
1 change: 0 additions & 1 deletion src/compute/take/generic_binary.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

use crate::{
array::{Array, GenericBinaryArray, Offset, PrimitiveArray},
bitmap::{Bitmap, MutableBitmap},
Expand Down
1 change: 0 additions & 1 deletion src/compute/take/primitive.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

use crate::{
array::{Array, PrimitiveArray},
bitmap::{Bitmap, MutableBitmap},
Expand Down