Skip to content

Commit

Permalink
Fix tests not working with Git 2.23
Browse files Browse the repository at this point in the history
Git now sanitizes the names given to worktrees, so use a name without
space to have a consistent behaviour whatever the Git version.
  • Loading branch information
koutcher committed Sep 21, 2019
1 parent f7e0a25 commit 0684b8c
Show file tree
Hide file tree
Showing 7 changed files with 43 additions and 43 deletions.
6 changes: 3 additions & 3 deletions test/diff/submodule-editor-diffstat-test
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,9 @@ include/api.h
EOF

assert_equals 'exec-env' <<EOF
- pwd=ROOT/work dir/repo-two-a
- git-dir=ROOT/work dir/.git/modules/repo-two-a
- pwd=ROOT/work-dir/repo-two-a
- git-dir=ROOT/work-dir/.git/modules/repo-two-a
- show-cdup=
- is-inside-work-tree=true
- show-superproject-working-tree=ROOT/work dir
- show-superproject-working-tree=ROOT/work-dir
EOF
30 changes: 15 additions & 15 deletions test/diff/submodule-editor-test
Original file line number Diff line number Diff line change
Expand Up @@ -360,33 +360,33 @@ EOF

assert_equals 'exec-env' <<EOF
default
- pwd=ROOT/work dir/bench
- git-dir=ROOT/work dir/.git/modules/bench
- pwd=ROOT/work-dir/bench
- git-dir=ROOT/work-dir/.git/modules/bench
- show-cdup=
- is-inside-work-tree=true
- show-superproject-working-tree=ROOT/work dir
- show-superproject-working-tree=ROOT/work-dir
sub-directory
- pwd=ROOT/work dir/bench/some/subdir
- git-dir=ROOT/work dir/.git/modules/bench
- pwd=ROOT/work-dir/bench/some/subdir
- git-dir=ROOT/work-dir/.git/modules/bench
- show-cdup=../../
- is-inside-work-tree=true
- show-superproject-working-tree=ROOT/work dir
- show-superproject-working-tree=ROOT/work-dir
sub-directory::exec
- pwd=ROOT/work dir/bench
- git-dir=ROOT/work dir/.git/modules/bench
- pwd=ROOT/work-dir/bench
- git-dir=ROOT/work-dir/.git/modules/bench
- show-cdup=
- is-inside-work-tree=true
- show-superproject-working-tree=ROOT/work dir
- show-superproject-working-tree=ROOT/work-dir
sub-directory-diffstat
- pwd=ROOT/work dir/bench/some/subdir
- git-dir=ROOT/work dir/.git/modules/bench
- pwd=ROOT/work-dir/bench/some/subdir
- git-dir=ROOT/work-dir/.git/modules/bench
- show-cdup=../../
- is-inside-work-tree=true
- show-superproject-working-tree=ROOT/work dir
- show-superproject-working-tree=ROOT/work-dir
sub-directory-diffstat::exec
- pwd=ROOT/work dir/bench
- git-dir=ROOT/work dir/.git/modules/bench
- pwd=ROOT/work-dir/bench
- git-dir=ROOT/work-dir/.git/modules/bench
- show-cdup=
- is-inside-work-tree=true
- show-superproject-working-tree=ROOT/work dir
- show-superproject-working-tree=ROOT/work-dir
EOF
24 changes: 12 additions & 12 deletions test/diff/worktree-editor-test
Original file line number Diff line number Diff line change
Expand Up @@ -355,38 +355,38 @@ EOF

assert_equals 'exec-env' <<EOF
default
- pwd=ROOT/work dir
- git-dir=ROOT/base/.git/worktrees/work dir
- pwd=ROOT/work-dir
- git-dir=ROOT/base/.git/worktrees/work-dir
- show-cdup=
- is-inside-work-tree=true
- show-superproject-working-tree=
default::exec
- pwd=ROOT/work dir
- git-dir=ROOT/base/.git/worktrees/work dir
- pwd=ROOT/work-dir
- git-dir=ROOT/base/.git/worktrees/work-dir
- show-cdup=
- is-inside-work-tree=true
- show-superproject-working-tree=
sub-directory
- pwd=ROOT/work dir/some/subdir
- git-dir=ROOT/base/.git/worktrees/work dir
- pwd=ROOT/work-dir/some/subdir
- git-dir=ROOT/base/.git/worktrees/work-dir
- show-cdup=../../
- is-inside-work-tree=true
- show-superproject-working-tree=
sub-directory::exec
- pwd=ROOT/work dir
- git-dir=ROOT/base/.git/worktrees/work dir
- pwd=ROOT/work-dir
- git-dir=ROOT/base/.git/worktrees/work-dir
- show-cdup=
- is-inside-work-tree=true
- show-superproject-working-tree=
sub-directory-diffstat
- pwd=ROOT/work dir/some/subdir
- git-dir=ROOT/base/.git/worktrees/work dir
- pwd=ROOT/work-dir/some/subdir
- git-dir=ROOT/base/.git/worktrees/work-dir
- show-cdup=../../
- is-inside-work-tree=true
- show-superproject-working-tree=
sub-directory-diffstat::exec
- pwd=ROOT/work dir
- git-dir=ROOT/base/.git/worktrees/work dir
- pwd=ROOT/work-dir
- git-dir=ROOT/base/.git/worktrees/work-dir
- show-cdup=
- is-inside-work-tree=true
- show-superproject-working-tree=
Expand Down
4 changes: 2 additions & 2 deletions test/main/git-alias-test
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ test_tig -- src/main/scala
in_work_dir git alias-vars

assert_equals 'alias-vars' <<EOF
PWD=ROOT/work dir
GIT_DIR=ROOT/base/.git/worktrees/work dir
PWD=ROOT/work-dir
GIT_DIR=ROOT/base/.git/worktrees/work-dir
GIT_PREFIX=deltablue/
EOF

Expand Down
2 changes: 1 addition & 1 deletion test/tools/libtest.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ prefix_dir="$(printf '%s\n' "$source_dir" | sed -n 's#\(.*/test/\)\([/].*\)*#\2#
output_dir="$base_dir/tmp/$prefix_dir/$test"
tmp_dir="$base_dir/tmp"
output_dir="$tmp_dir/$prefix_dir/$test"
work_dir="work dir"
work_dir="work-dir"
tty_attrs="$(stty -g </dev/tty)"

# The locale must specify UTF-8 for Ncurses to output correctly. Since C.UTF-8
Expand Down
12 changes: 6 additions & 6 deletions test/tree/submodule-editor-test
Original file line number Diff line number Diff line change
Expand Up @@ -98,15 +98,15 @@ EOF

assert_equals 'exec-env' <<EOF
start
- pwd=ROOT/work dir/bench/common/src
- git-dir=ROOT/work dir/.git/modules/bench
- pwd=ROOT/work-dir/bench/common/src
- git-dir=ROOT/work-dir/.git/modules/bench
- show-cdup=../../
- is-inside-work-tree=true
- show-superproject-working-tree=ROOT/work dir
- show-superproject-working-tree=ROOT/work-dir
end
- pwd=ROOT/work dir/bench
- git-dir=ROOT/work dir/.git/modules/bench
- pwd=ROOT/work-dir/bench
- git-dir=ROOT/work-dir/.git/modules/bench
- show-cdup=
- is-inside-work-tree=true
- show-superproject-working-tree=ROOT/work dir
- show-superproject-working-tree=ROOT/work-dir
EOF
8 changes: 4 additions & 4 deletions test/tree/worktree-editor-test
Original file line number Diff line number Diff line change
Expand Up @@ -95,14 +95,14 @@ EOF

assert_equals 'exec-env' <<EOF
start
- pwd=ROOT/work dir/common/src
- git-dir=ROOT/base/.git/worktrees/work dir
- pwd=ROOT/work-dir/common/src
- git-dir=ROOT/base/.git/worktrees/work-dir
- show-cdup=../../
- is-inside-work-tree=true
- show-superproject-working-tree=
end
- pwd=ROOT/work dir
- git-dir=ROOT/base/.git/worktrees/work dir
- pwd=ROOT/work-dir
- git-dir=ROOT/base/.git/worktrees/work-dir
- show-cdup=
- is-inside-work-tree=true
- show-superproject-working-tree=
Expand Down

0 comments on commit 0684b8c

Please sign in to comment.