-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for basv3
#482
base: master
Are you sure you want to change the base?
Conversation
@john30 What's your policy regarding register names? |
@GuyHarg If all goes well, and depending on how your VRC 720 is supported, |
I'd rather stick to short names for common things like heat circuit="hc", hot water circuit="hwc" etc as otherwise the names grow awfully and unnecessary long, see here /~https://github.com/john30/ebusd-configuration#component-type-names and for ease of use messages revealing a single value only should carry the field name "value". also I'd rather prevent reinvention of the same, i.e. if a message with a suitable name exists elsewhere: use it and rather later do refactoring overall (as is ongoing with the typespec conversion) |
@john30 Roger that! I‘ll try to keep them short.
Already the case for all my definitions. 👌
Sounds good! It’s certainly easier to refactor when naming is consistent. Lastly, as there isn’t a good generic configuration for the |
hi @burmistrzak, till now i was using CTLV2 config from jonesPD's repo for my regulator, which is (i think a quite early VRC70) identified as "720" in ebusd and I though I give it a try with this basv3 config. I have to say it works almost flawlessly. :) Few things I noticed:
Similar issue for Zone names.
All in all I think this could be used as a baseline even for devices identified as "720", "ctlv*", "basv*"? |
@kgeree Nice, thanks the detailed feedback!
As these system regulators have a lot in common, I can certainly see that happening. 😊 Edit: Did you properly clone my fork and checkout the Edit 2: Various fixes are now available in |
@john30 Do we already have an option to specify min/max/step values for registers? Edit: I guess this answers my first question? 👀 Edit 2: Edit 3: Just saw that support for |
@kgeree Were you able to checkout the |
Afaik each register can only a limited set of characters, so two registers are needed for the whole number. However, if you don't program a long enough number in the regulator, you can't read the second register because it is empty. Have you checked this scenario?
You can set a dew point offset for each heating circuit per the definition in the VRC720 manual: the minimum supply flow temperature in cooling mode is determined by the calculated dew point + this offset |
not yet...will try later. However looking at the vwzio, I think I have some more values..not sure if you can utilize something, they're all working for me (its a CSV that still needs the tempate files...) HMU and 720 looks good for the first sight (however I'm using ebusd in r/o mode yet) so can't speak for the write options... |
@kgeree The See here: ebusd-configuration/src/vaillant/08.hmu.tsp Line 791 in 08a68f1
|
okay...I gave it a try, have the following results:
and I get "null" for the following: (but i think vwzio shall not be discussed in this PR) |
@kgeree Yes, likely.
You get
Yeah, #481 is definitely a better fit. 😊 |
right, null, but no errors. BTW is there a way to show "null" in HomeAssistant as well? then I'd get "Unknown" only if there is really an error on the ebus layer... |
@kgeree Alright, that’s good news! The
There’s probably a way to do that, but it likely requires modifying the MQTT-HASSIO configuration (value template, etc.)... I‘d say that‘s something to look at when we’ve worked out all other issues. 😉 |
nicely working: |
@kgeree Great! ✌️
Maybe..? |
Seems i get some inconsistent readings.. Error on:
Error off:
|
@kgeree Ok, decoding based on currently available definitions yields:
What is shown under error history on the system regulator itself? |
I think in order to get proper values for historic entries an index has to be added. errors.inc _templates.csv: e.g.
This would translate to:
In my case (no errors in regulator history) this yields for all values:
|
|
@kgeree Thx! Can you please run |
here you go:
|
@kgeree Alright, decoding based on the definition @chrizzzp provided:
Edit: Question now is the meaning of Edit 2: Messed up the conversion above by including the index. It's now fixed. Regarding |
@kgeree New build on the You'll have to manually read history entries, as they aren't polled automatically. E.g.:
The value of |
for me index is working up to 9 (10 entries - just as it is shown on the regulator as well)
BTW its called "Fault history" on the regulator :) |
@kgeree Yea, Fault History is the correct terminology. 😅
Can you please share the output of Edit: Regarding MQTT, there‘re good docs available. E.g.: To send the index along with your /get request, you simply put the number in the MQTT payload. |
version: ebusd 24.1.p20241115 |
Yes, this is unfortunate. One could also include the unit 'hours' in the name: e.g. |
@kgeree Huh, that’s interesting. Instead of Can you please simulate another fault – do not clear it, and post the corresponding history entry as hex? |
@chrizzzp That‘s what I was thinking as well, but naming the Enum is tricky. E.g.: Btw. support for value ranges is coming to |
Is this what you mean?
It seems it shows as "resolved" even if if the error still persists. |
@kgeree Almost. 😉
We're particularly interested in this byte here: |
fault present:
fault resolved
so no change there |
@kgeree Thx! Looks like the |
@chrizzzp There‘re new options available in the myVaillant app! I already tried capturing the register for Upper correction value, but nothing seem to come up..? 🤔 |
As I have only temporary 'External DHW' via VR71 (heating circuit configured as external DHW), these settings don't show up for me in the app... |
@chrizzzp Hmm, you mean Circuit type: DHW on the system regulator? |
@kgeree Can you help out here? 😊 |
Correct, 'external DHW' is a rather personal nomenclature to differentiate it from the regular (internal) DHW circuit. It also operates an external valve. |
I simply don't even have "Energy management" under Settings -> Control. :) |
@kgeree Huh, strange. You do have the option Heating curve settings available, right? |
Heat curve settings I have, which is working badly...I once tried to change heat curve for 1 circuit and it changed for all 3 :|..since that I rather not touch... |
@kgeree I guess that’s the reason then. |
This PR aims to be the most feature-complete and robust definition for the VRC720 sensoCOMFORT line of system regulators.
It's also entirely written in TypeSpec, and already prepared to take advantage of the upcoming
range
validation feature for numeric values.Follow-up for #462 to keep patches manageable.