refactor(Sequence): treat invalid Status as Failure

This change brings Sequence in line with the other implementations in this
package, such as All, and has no impact in normal operation / on Tick
implementations which are implemented correctly.

behaviortree.go

@@ -23,9 +23,9 @@ import (
 )
 
 const (
-	_ = iota
+	_ Status = iota
 	// Running indicates that the Tick for a given Node is currently running
-	Running Status = iota
+	Running
 	// Success indicates that the Tick for a given Node completed successfully
 	Success
 	// Failure indicates that the Tick for a given Node failed to complete successfully

sequence.go

@@ -27,7 +27,7 @@ func Sequence(children []Node) (Status, error) {
 		if status == Running {
 			return Running, nil
 		}
-		if status == Failure {
+		if status != Success {
 			return Failure, nil
 		}
 	}

sequence_test.go

@@ -258,3 +258,26 @@ func TestSequence_running(t *testing.T) {
 		t.Error("expected nil error but it was", err)
 	}
 }
+
+func TestSequence_invalidStatus(t *testing.T) {
+	var (
+		output   []int
+		children []Node
+	)
+	for i := 0; i < 6; i++ {
+		i := i
+		children = append(children, New(func([]Node) (Status, error) {
+			output = append(output, i)
+			if i == 3 {
+				return 0, nil
+			}
+			return Success, nil
+		}))
+	}
+	if status, err := NewNode(Sequence, children).Tick(); err != nil || status != Failure {
+		t.Error(status, err)
+	}
+	if diff := deep.Equal(output, []int{0, 1, 2, 3}); diff != nil {
+		t.Errorf("%v\n%s", output, strings.Join(diff, "\n"))
+	}
+}

ticker_test.go

@@ -207,7 +207,7 @@ func TestNewTicker_runError(t *testing.T) {
 func TestNewTicker_runCancel(t *testing.T) {
 	startGoroutines := runtime.NumGoroutine()
 	defer func() {
-		time.Sleep(time.Millisecond * 50)
+		time.Sleep(time.Millisecond * 100)
 
 		endGoroutines := runtime.NumGoroutine()
 
@@ -226,7 +226,7 @@ func TestNewTicker_runCancel(t *testing.T) {
 	startedAt := time.Now()
 	defer func() {
 		diff := time.Now().Sub(startedAt)
-		if diff > time.Millisecond*20 {
+		if diff > time.Millisecond*100 {
 			t.Error("unexpected diff", diff)
 		}
 	}()