Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: prevent duplicate analytics entries by sequential executions #3249

Merged
merged 2 commits into from
Jan 21, 2025
Merged

bugfix: prevent duplicate analytics entries by sequential executions #3249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3006b3
bugfix: prevent duplicate analytics entries by sequential executions
nakedfool Jan 21, 2025
5656423
bugfix: add try/catchh in othher performAnalytics fn
nakedfool Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/react-app-revamp/hooks/useCastVotes/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,12 @@ export function useCastVotes() {
}

async function performAnalytics(params: CombinedAnalyticsParams) {
await Promise.all([addUserActionAnalytics(params), updateRewardAnalyticsIfNeeded(params)]);
try {
await addUserActionAnalytics(params);
await updateRewardAnalyticsIfNeeded(params);
} catch (error) {
console.error("Error in performAnalytics:", error);
}
}

return {
Expand Down
7 changes: 6 additions & 1 deletion packages/react-app-revamp/hooks/useSubmitProposal/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,12 @@ export function useSubmitProposal() {
}

async function performAnalytics(params: CombinedAnalyticsParams) {
await Promise.all([addUserActionAnalytics(params), updateRewardAnalyticsIfNeeded(params)]);
try {
await addUserActionAnalytics(params);
await updateRewardAnalyticsIfNeeded(params);
} catch (error) {
console.error("Error in performAnalytics:", error);
}
}

return {
Expand Down
Loading