Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Scan - The projectKey query param should be added if the default project is used #869

Merged
merged 2 commits into from
Dec 23, 2023
Merged

Build Scan - The projectKey query param should be added if the default project is used #869

merged 2 commits into from
Dec 23, 2023

Conversation

bhanurp
Copy link
Contributor

@bhanurp bhanurp commented Dec 9, 2023 •
edited
Loading

… version is above 3.77

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@bhanurp bhanurp changed the title #868 Included project key in post request to build scan API when XRAY… #868 Fix for missing projectKey in xray_data_url response on build scan Dec 9, 2023
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Dec 23, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 23, 2023
@eyalbe4 eyalbe4 added bug Something isn't working safe to test Approve running integration tests on a pull request labels Dec 23, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 23, 2023
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

@eyalbe4 eyalbe4 changed the title #868 Fix for missing projectKey in xray_data_url response on build scan Build Scan - Avoid adding projectKey param if the default project is used Dec 23, 2023
@eyalbe4 eyalbe4 changed the title Build Scan - Avoid adding projectKey param if the default project is used Build Scan - Avoid adding the projectKey query param if the default project is used Dec 23, 2023
@eyalbe4 eyalbe4 merged commit 0c37ff3 into jfrog:dev Dec 23, 2023
@eyalbe4 eyalbe4 changed the title Build Scan - Avoid adding the projectKey query param if the default project is used Build Scan - The projectKey query param should added if the default project is used Dec 25, 2023
@eyalbe4 eyalbe4 changed the title Build Scan - The projectKey query param should added if the default project is used Build Scan - The projectKey query param should be added if the default project is used Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asafgabai asafgabai Awaiting requested review from asafgabai

@yahavi yahavi Awaiting requested review from yahavi

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhanurp @eyalbe4