-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/custom messages #10292
Closed
kunal-kushwaha
wants to merge
15
commits into
jestjs:master
from
MLH-Fellowship:feature/custom-messages
Closed
Feature/custom messages #10292
kunal-kushwaha
wants to merge
15
commits into
jestjs:master
from
MLH-Fellowship:feature/custom-messages
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est into feature/custom-messages
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reference: #9662
The original PR by @rogeliog #9662 profoundly inspires the current PR. This extended PR attempts to fix the changes suggested by @SimenB before, rebasing it with the current master HEAD and minor code refactorings.
This PR can be a good start towards PR #10227 (Reporting individual Test cases). As an independent PR, it allows custom messages to be sent to parent from the worker process when it's being run as an event listener.
Test plan
An extension from #9662
Acknowledgements
@sauravhiremath for his super awesome contribution 🚀 🚀
@rogeliog for laying down the foundation for this PR. 🚀
@SimenB and @jevakallio for their time and reviews 👏