Add workaround

jeroen · Dec 23, 2024 · 9b25cf7 · 9b25cf7
1 parent c56ea88
commit 9b25cf7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/R/parser.R b/R/parser.R
@@ -67,6 +67,12 @@ curl_parse_url <- function(url, baseurl = NULL, decode = TRUE, params = TRUE){
   stopifnot(is.character(url))
   stopifnot(length(url) == 1)
   baseurl < as.character(baseurl)
+
+  # Workaround for #366
+  if(substr(url, 1, 1) == '#' && (compareVersion(curl_version()$version, "8.8.0") < 0)){
+    url <- sub('(#.*)?$', url, baseurl)
+  }
+
   result <- .Call(R_parse_url, url, baseurl)
   if(inherits(result, 'ada')){
     result <- normalize_ada(result)

diff --git a/tests/testthat/test-parser.R b/tests/testthat/test-parser.R
@@ -51,8 +51,9 @@ test_that("Decoding parameters", {
 })
 
 test_that("Parse fragment only", {
-  out <- curl_parse_url("#foo", "http://x.com/a/b/c")
-  expect_equal(out$path, '/a/b/c')
-  expect_equal(out$fragment, 'foo')
+  baseurl <- "http://x.com/a/b/c?bla=123&foo=yolo#foo"
+  out <- curl_parse_url("#foo", baseurl)
+  out2 <- curl_parse_url(baseurl)
+  expect_equal(out, out2)
 })