Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency org.jvnet.hudson.plugins:analysis-pom to v7.3.0 #245

Merged
merged 5 commits into from
Feb 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<parent>
<groupId>org.jvnet.hudson.plugins</groupId>
<artifactId>analysis-pom</artifactId>
<version>7.1.0</version>
<version>7.3.0</version>
<relativePath />
</parent>

Expand All @@ -18,12 +18,11 @@
<description>Defines an API for Jenkins to publish checks to SCM platforms.</description>

<properties>
<revision>2.0.3</revision>
<revision>2.1.0</revision>
<changelist>-SNAPSHOT</changelist>
<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>

<testcontainers.version>1.19.0</testcontainers.version>
<plugin-util-api.version>4.1.0</plugin-util-api.version>
<testcontainers.version>1.19.6</testcontainers.version>
</properties>

<licenses>
Expand All @@ -45,7 +44,6 @@
<dependency>
<groupId>io.jenkins.plugins</groupId>
<artifactId>plugin-util-api</artifactId>
<version>${plugin-util-api.version}</version>
</dependency>
<dependency>
<groupId>io.jenkins.plugins</groupId>
Expand All @@ -58,7 +56,6 @@
<dependency>
<groupId>io.jenkins.plugins</groupId>
<artifactId>plugin-util-api</artifactId>
<version>${plugin-util-api.version}</version>
<classifier>tests</classifier>
<scope>test</scope>
</dependency>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -156,15 +156,15 @@ public void shouldPublishStageDetails() {
ChecksDetails details = checksDetails.get(0);
assertThat(details.getStatus()).isEqualTo(ChecksStatus.QUEUED);
assertThat(details.getConclusion()).isEqualTo(ChecksConclusion.NONE);
assertThat(details.getName()).isPresent().get().isEqualTo("Test Status");
assertThat(details.getName()).isPresent().contains("Test Status");
assertThat(details.getOutput()).isNotPresent();

// Details 1, first stage
details = checksDetails.get(1);
assertThat(details.getStatus()).isEqualTo(ChecksStatus.IN_PROGRESS);
assertThat(details.getConclusion()).isEqualTo(ChecksConclusion.NONE);
assertThat(details.getOutput()).isPresent().get().satisfies(output -> {
assertThat(output.getTitle()).isPresent().get().isEqualTo("In progress");
assertThat(output.getTitle()).isPresent().contains("In progress");
assertThat(output.getSummary()).isPresent().get().satisfies(StringUtils::isBlank);
assertThat(output.getText()).isPresent().get().asString().contains("* Simple Stage *(running)*");
});
Expand All @@ -174,16 +174,16 @@ public void shouldPublishStageDetails() {
assertThat(details.getOutput()).isPresent().get().satisfies(output -> {
assertThat(output.getSummary()).isPresent().get().satisfies(StringUtils::isBlank);
assertThat(output.getText()).isPresent().get().satisfies(text -> {
assertThat(output.getTitle()).isPresent().get().isEqualTo("In progress");
assertThat(text).matches(Pattern.compile(".*\\* Simple Stage \\*\\([^)]+\\)\\*.*", Pattern.DOTALL));
assertThat(text).contains(" * In parallel *(running)*");
assertThat(output.getTitle()).isPresent().contains("In progress");
assertThat(text).doesNotContain("* Simple Stage *(running)*");
assertThat(text).contains("* Simple Stage", "* In parallel *(running)*");
});
});

// Details 6, p1s1 has finished and emitted unstable
details = checksDetails.get(6);
assertThat(details.getOutput()).isPresent().get().satisfies(output -> {
assertThat(output.getTitle()).isPresent().get().isEqualTo("In parallel/p1/p1s1: warning in 'unstable' step");
assertThat(output.getTitle()).isPresent().contains("In parallel/p1/p1s1: warning in 'unstable' step");
assertThat(output.getSummary()).isPresent().get().asString().isEqualToIgnoringNewLines(""
+ "### `In parallel / p1 / p1s1 / Set stage result to unstable`\n"
+ "Warning in `unstable` step, with arguments `something went wrong`.\n"
Expand Down
Loading