Skip to content

Commit

Permalink
Remove hanami-controllers Gem as dependency.
Browse files Browse the repository at this point in the history
Early tests had used it for session data, which we no longer directly access in this Gem.

79 tests, 108 assertions, 0 failures, 0 errors, 0 skips
Coverage: 909 / 909 LOC (100.0%) covered.
RuboCop: 11 files inspected, no offenses detected
Flay: Total score 0
Flog: Total 329.8; method average 4.6; max 9.8 (CryptIdent::SignUp#create_result)
Reek: 0 total warnings
Inch: Nothing to suggest
  • Loading branch information
jdickey committed Dec 20, 2018
1 parent 4e438c9 commit 2f6c03c
Show file tree
Hide file tree
Showing 5 changed files with 52 additions and 60 deletions.
55 changes: 25 additions & 30 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
PATH
remote: .
specs:
crypt_ident (0.1.0)
crypt_ident (0.1.1)
bcrypt
dry-matcher
dry-monads
hanami-controller
hanami-model

GEM
Expand Down Expand Up @@ -97,9 +96,6 @@ GEM
guard-shell (0.7.1)
guard (>= 2.0.0)
guard-compat (~> 1.0)
hanami-controller (1.3.0)
hanami-utils (~> 1.3)
rack (~> 2.0)
hanami-model (1.3.0)
concurrent-ruby (~> 1.0)
dry-types (~> 0.11.0)
Expand Down Expand Up @@ -156,7 +152,6 @@ GEM
pry-doc (0.13.5)
pry (~> 0.11)
yard (~> 0.9.11)
rack (2.0.6)
rainbow (3.0.0)
rake (12.3.2)
rb-fsevent (0.10.3)
Expand Down Expand Up @@ -231,31 +226,31 @@ PLATFORMS
ruby

DEPENDENCIES
bundler
bundler (>= 1.17.2)
crypt_ident!
flay
flog
github-markup
guard
guard-minitest
guard-rake
guard-rubocop
guard-shell
inch
minitest
minitest-hooks
minitest-matchers
minitest-reporters
minitest-tagz
pry-byebug
pry-doc
rake
redcarpet
reek
rubocop
simplecov
yard
yard-classmethods
flay (= 2.12.0)
flog (= 4.6.2)
github-markup (= 3.0.2)
guard (= 2.15.0)
guard-minitest (= 2.4.6)
guard-rake (= 1.0.0)
guard-rubocop (= 1.3.0)
guard-shell (= 0.7.1)
inch (= 0.8.0)
minitest (= 5.11.3)
minitest-hooks (= 1.5.0)
minitest-matchers (= 1.4.1)
minitest-reporters (= 1.3.5)
minitest-tagz (= 1.6.0)
pry-byebug (= 3.6.0)
pry-doc (= 0.13.5)
rake (>= 12.3.2)
redcarpet (= 3.4.0)
reek (= 5.2.0)
rubocop (= 0.61.1)
simplecov (= 0.16.1)
yard (= 0.9.16)
yard-classmethods (= 1.0.0)

BUNDLED WITH
1.17.2
49 changes: 24 additions & 25 deletions crypt_ident.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -43,37 +43,36 @@ Gem::Specification.new do |spec|
#
spec.add_runtime_dependency 'bcrypt'
spec.add_runtime_dependency 'hanami-model'
spec.add_runtime_dependency 'hanami-controller'
spec.add_runtime_dependency 'dry-matcher'
spec.add_runtime_dependency 'dry-monads'

spec.add_development_dependency "bundler" # , '>= 1.16.6'
spec.add_development_dependency "rake" # , '>= 12.3.2'
spec.add_development_dependency "minitest" # , '5.11.3'
spec.add_development_dependency 'flay' #, '2.12.0'
spec.add_development_dependency 'flog' #, '4.6.2'
spec.add_development_dependency 'inch' #, '0.8.0'
spec.add_development_dependency "bundler", '>= 1.17.2'
spec.add_development_dependency "rake", '>= 12.3.2'
spec.add_development_dependency "minitest", '5.11.3'
spec.add_development_dependency 'flay', '2.12.0'
spec.add_development_dependency 'flog', '4.6.2'
spec.add_development_dependency 'inch', '0.8.0'
# spec.add_development_dependency 'minitest-fail-fast' #, '0.1.0'
spec.add_development_dependency 'minitest-hooks' #, '1.5.0'
spec.add_development_dependency 'minitest-matchers' #, '1.4.1'
spec.add_development_dependency 'minitest-reporters' #, '1.3.5'
spec.add_development_dependency 'minitest-tagz' #, '1.6.0'
spec.add_development_dependency 'minitest-hooks', '1.5.0'
spec.add_development_dependency 'minitest-matchers', '1.4.1'
spec.add_development_dependency 'minitest-reporters', '1.3.5'
spec.add_development_dependency 'minitest-tagz', '1.6.0'
# XXX: Great idea; useful; but we've found a way to work around what we were
# looking to use this Gem to help with.
# spec.add_development_dependency 'monotime' #, '0.6.1'
spec.add_development_dependency 'pry-byebug' #, '3.6.0'
spec.add_development_dependency 'pry-doc' #, '0.13.5'
spec.add_development_dependency 'reek' #, '5.2.0'
spec.add_development_dependency 'rubocop' # , '0.61.1'
spec.add_development_dependency 'simplecov' #, '0.16.1'
spec.add_development_dependency 'yard' #, '0.9.16'
spec.add_development_dependency 'yard-classmethods' #, '1.0.0'
spec.add_development_dependency 'github-markup' #, '3.0.2'
spec.add_development_dependency 'redcarpet' #, '3.4.0'
spec.add_development_dependency 'pry-byebug', '3.6.0'
spec.add_development_dependency 'pry-doc', '0.13.5'
spec.add_development_dependency 'reek', '5.2.0'
spec.add_development_dependency 'rubocop', '0.61.1'
spec.add_development_dependency 'simplecov', '0.16.1'
spec.add_development_dependency 'yard', '0.9.16'
spec.add_development_dependency 'yard-classmethods', '1.0.0'
spec.add_development_dependency 'github-markup', '3.0.2'
spec.add_development_dependency 'redcarpet', '3.4.0'

spec.add_development_dependency 'guard' #, '2.15.0'
spec.add_development_dependency 'guard-minitest' #, '2.4.6'
spec.add_development_dependency 'guard-rake' #, '1.0.0'
spec.add_development_dependency 'guard-rubocop' #, '1.3.0'
spec.add_development_dependency 'guard-shell' #, '0.7.1'
spec.add_development_dependency 'guard', '2.15.0'
spec.add_development_dependency 'guard-minitest', '2.4.6'
spec.add_development_dependency 'guard-rake', '1.0.0'
spec.add_development_dependency 'guard-rubocop', '1.3.0'
spec.add_development_dependency 'guard-shell', '0.7.1'
end
2 changes: 1 addition & 1 deletion lib/crypt_ident/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@

module CryptIdent
# Version number for Gem. Uses Semantic Versioning.
VERSION = '0.1.0'
VERSION = '0.1.1'
end
2 changes: 1 addition & 1 deletion scripts/build-gem-list.rb
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def gem_strings(list)
'guard-rake:1.0.0',
'guard-rubocop:1.3.0',
'guard-shell:0.7.1',
'hanami-controller:1.3.0',
# 'hanami-controller:1.3.0',
'hanami-model:1.3.0',
'inch:0.8.0',
# 'minitest-fail-fast:0.1.0',
Expand Down
4 changes: 1 addition & 3 deletions test/test_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,8 @@
tags << 'focus'
Minitest::Tagz.choose_tags(*tags, run_all_if_no_match: true)

require 'hanami/controller'
require 'hanami/action'
require 'hanami/action/session'
require 'hanami/model'
require 'hanami/utils/kernel'

# reporter_name = ENV['REPORTER'] || 'SpecReporter'
reporter_name = ENV['REPORTER'] || 'DefaultReporter'
Expand Down

0 comments on commit 2f6c03c

Please sign in to comment.