Reimplement custom_vjp.optimize_remat using custom_dce
#26814
+58
−245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfm
force-pushed
the
remat-opt-custom-dce
branch
from
8a67fbe to
6c4cb0b
Compare
dfm
force-pushed
the
remat-opt-custom-dce
branch
from
6c4cb0b to
10756cb
Compare
froystig
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "optimize remat" feature of
jax.custom_vjpwas just a special case ofcustom_dce, so we can delete a lot of duplicated code by reimplementing that feature usingcustom_dce. I don't anticipate that this will change any behavior.