Skip to content

Commit

Permalink
[CI] Fix cache resolution and syntax in check binary size workflow (#…
Browse files Browse the repository at this point in the history
…2591)

## Which problem is this PR solving?
- Resolves #2590

## Description of the changes
- 

## How was this change tested?
- 

## Checklist
- [ ] I have read
/~https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [ ] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [ ] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

Signed-off-by: chahatsagarmain <chahatsagar2003@gmail.com>
  • Loading branch information
chahatsagarmain authored Jan 17, 2025
1 parent 1ee19c2 commit 1178b1c
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions .github/workflows/check_bundle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,11 @@ jobs:
with:
path: bundle_size.txt
key: jaeger-ui-bundle-size
restore-keys: |
jaeger-ui-bundle-size
- name: Compare bundle sizes
if: steps.cache-bundle-size.outputs.cache-hit == 'true'
if: steps.cache-bundle-size.outputs.cache-matched-key != ''
run: |
OLD_BUNDLE_SIZE=$(cat bundle_size.txt)
NEW_BUNDLE_SIZE=$(cat new_bundle_size.txt)
Expand All @@ -62,8 +64,8 @@ jobs:
run: mv new_bundle_size.txt bundle_size.txt

- name: Save new bundle size
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
if: ${{ (github.event_name == 'push') && (github.ref == 'refs/heads/main') }}
uses: actions/cache/save@v4
with:
path: bundle_size.txt
key: jaeger-ui-bundle-size
key: jaeger-ui-bundle-size-${{ github.run_id }}

0 comments on commit 1178b1c

Please sign in to comment.