fix: resolve potential errors during garbage collection process

izure1 · Nov 20, 2024 · ec6e8ed · ec6e8ed
1 parent 2d2fa74
commit ec6e8ed
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 11 deletions.
diff --git a/deno.json b/deno.json
@@ -1,6 +1,6 @@
 {
   "name": "@izure/cache-entanglement",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "description": "Manage caches that are dependent on each other efficiently.",
   "author": "izure1 <admin@izure.org>",
   "license": "MIT",

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "cache-entanglement",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "description": "Manage caches that are dependent on each other efficiently.",
   "main": "dist/cjs/index.cjs",
   "module": "dist/esm/index.mjs",
@@ -32,7 +32,6 @@
   "license": "MIT",
   "devDependencies": {
     "@types/jest": "^29.5.13",
-    "@types/ungap__structured-clone": "^1.2.0",
     "esbuild": "^0.24.0",
     "jest": "^29.7.0",
     "ts-jest": "^29.2.5",

diff --git a/src/CacheEntanglement.ts b/src/CacheEntanglement.ts
@@ -1,5 +1,5 @@
 import type { CacheData } from './CacheData'
-import { InvertedWeakMap } from './utils/InvertWeakMap'
+import { InvertedWeakMap } from './utils/InvertedWeakMap'
 
 type Deferred<T> = T|Promise<T>
 type ValueRecord<T> = { [key: string]: T }

diff --git a/src/utils/InvertWeakMap.ts → src/utils/InvertedWeakMap.ts b/src/utils/InvertWeakMap.ts → src/utils/InvertedWeakMap.ts
@@ -12,6 +12,13 @@ export class InvertedWeakMap<K extends string|number|symbol, V extends WeakKey>
   }
 
   delete(key: K): boolean {
+    const ref = this._map.get(key)
+    if (ref) {
+      const raw = ref.deref()
+      if (raw !== undefined) {
+        this._registry.unregister(raw)
+      }
+    }
     return this._map.delete(key)
   }