Use fpurge/__fpurge to cancel buffered output #366
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to NOIRLAB IRAFs 48b2f61, which defines fcancel() as setvbuf() on macOS:
iraf/unix/os/zxwhen.c
Lines 90 to 96 in 3761a03
setvbuf() is not what fcancel() is supposed to do, namely to cancel any buffered output. Instead, it just makes the output unbuffered. i.e. when applying this patch, stdout will become unbuffered for the rest of the session after ^C. Also, setvbuf() is not macOS specific but part of the standard C library (and therefore also available for Linux). And, hard-coding
_IONBF
instead of using the proper include file (stdio.h
) is bad style.The better solution (although non-portable) is to use fpurge() on macOS (and BSD variants), and __fpurge() on Linux (and glibc variants, like HURD). This is done in this PR. While not really portable, these are the libc functions for this task. Linux is covered with the
__GLIBC__
macro here, because it is not a Linux but a glibc feature. HURD is handled like Linux.@mjfitzpatrick, FYI.