fix size_t conversion issue that was failing to build on some compile…

…rs in the sdist
interpretml · Jan 17, 2025 · 2daf538 · 2daf538
1 parent 1d45042
commit 2daf538
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/docs/benchmarks/ebm-benchmark.ipynb b/docs/benchmarks/ebm-benchmark.ipynb
@@ -17,7 +17,7 @@
     "force_recreate = False\n",
     "exist_ok = True\n",
     "TIMEOUT_SEC = 60 * 60 * 24 * 180  # 180 days\n",
-    "wheel_filepaths = ['interpret_core-0.6.8-py3-none-any.whl', 'powerlift-0.1.12-py3-none-any.whl']\n",
+    "wheel_filepaths = ['interpret_core-0.6.9-py3-none-any.whl', 'powerlift-0.1.12-py3-none-any.whl']\n",
     "\n",
     "import datetime\n",
     "experiment_name = datetime.datetime.now().strftime('%Y_%m_%d_%H%M__') + 'myexperiment'\n",

diff --git a/shared/libebm/PartitionMultiDimensionalCorner.cpp b/shared/libebm/PartitionMultiDimensionalCorner.cpp
@@ -240,7 +240,7 @@ template<bool bHessian, size_t cCompilerScores> class PartitionMultiDimensionalC
          } while(cRealDimensions != iDimInit);
       }
 
-      const size_t cTotalSamples = pTotal->GetCountSamples();
+      const size_t cTotalSamples = static_cast<size_t>(pTotal->GetCountSamples());
 
       TensorSumDimension
             aDimensions[k_dynamicDimensions == cCompilerDimensions ? k_cDimensionsMax : cCompilerDimensions];
@@ -286,8 +286,8 @@ template<bool bHessian, size_t cCompilerScores> class PartitionMultiDimensionalC
 #endif // NDEBUG
             );
 
-            if(cSamplesLeafMin <= pTempBin->GetCountSamples()) {
-               const size_t cSamplesOther = cTotalSamples - pTempBin->GetCountSamples();
+            if(cSamplesLeafMin <= static_cast<size_t>(pTempBin->GetCountSamples())) {
+               const size_t cSamplesOther = cTotalSamples - static_cast<size_t>(pTempBin->GetCountSamples());
                if(cSamplesLeafMin <= cSamplesOther) {
                   EBM_ASSERT(1 <= cScores);
                   size_t iScore = 0;

diff --git a/shared/libebm/tests/boosting_unusual_inputs.cpp b/shared/libebm/tests/boosting_unusual_inputs.cpp
@@ -2289,7 +2289,8 @@ static double RandomizedTesting(const AccelerationFlags acceleration) {
          TermBoostFlags_PurifyUpdate,
          // TermBoostFlags_GradientSums, // does not return a metric
          TermBoostFlags_DisableNewtonUpdate,
-         TermBoostFlags_RandomSplits};
+         TermBoostFlags_RandomSplits,
+         TermBoostFlags_Corners};
    std::vector<IntEbm> boostFlagsChoose{
          TermBoostFlags_Default, TermBoostFlags_MissingLow, TermBoostFlags_MissingHigh, TermBoostFlags_MissingSeparate};
 
@@ -2367,7 +2368,7 @@ static double RandomizedTesting(const AccelerationFlags acceleration) {
 }
 
 TEST_CASE("stress test, boosting") {
-   const double expected = 12298977636064.098;
+   const double expected = 14219338182453.824;
 
    double validationMetricExact = RandomizedTesting(AccelerationFlags_NONE);
    CHECK(validationMetricExact == expected);