Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes a handful of notable changes:
CreateFunction
accepts the client and returns an error.NewHandler
accepts the client.NewClient
.Handler
private.These breaking changes are evident in this example file:
/~https://github.com/inngest/inngestgo/pull/92/files#diff-2bbb903e4dd6d4106cc1be9a7ba97c4f4d4a7eb08791721637e64bd30fd45718
Motivation
step.Send
only usingDefaultClient
.DefaultClient
.step.Invoke
doesn't need to be given the app ID (it's implicitly on the invoked function).More generally, these changes align the Go SDK a little more with our other SDKs.