-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fullscreen-trigger-for directive #86
base: main
Are you sure you want to change the base?
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ca924ac. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
|
||
it('should create an instance', () => { | ||
directive = new FullscreenTriggerForDirective(document); | ||
expect(directive).toBeTruthy(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please write some tests? e.g. test that requestFullscreen
is called on the correct target element.
FullscreenTriggerForDirective | ||
], | ||
}) | ||
export class FullscreenTriggerForModule { } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can use a standalone directive, would get rid of the module file
Description
Adding a fullscreen directive.
Fixes #85
Type of change
Checklist: