Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type of onClick for Link component in Vue #1701

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Fix type of onClick for Link component in Vue #1701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a1a20a
Fix type of `onClick` for Link component in Vue
reinink Oct 11, 2023
6c009c4
Update changelog
reinink Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ For changes prior to v1.0.0, see the [legacy releases](https://legacy.inertiajs.

## [Unreleased](/~https://github.com/inertiajs/inertia/compare/v1.0.11...HEAD)

- Nothing!
- Fix type of `onClick` for `Link` component in React and Vue ([#1699](/~https://github.com/inertiajs/inertia/pull/1699), [#1701](/~https://github.com/inertiajs/inertia/pull/1701))

## [v1.0.11](/~https://github.com/inertiajs/inertia/compare/v1.0.10...v1.0.11)

Expand Down
2 changes: 1 addition & 1 deletion packages/vue2/src/link.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export interface InertiaLinkProps {
href: string
method?: Method
headers?: Record<string, string>
onClick?: (event: MouseEvent | KeyboardEvent) => void
onClick?: (event: MouseEvent) => void
preserveScroll?: PreserveStateOption
preserveState?: PreserveStateOption
replace?: boolean
Expand Down
2 changes: 1 addition & 1 deletion packages/vue3/src/link.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export interface InertiaLinkProps {
href: string
method?: Method
headers?: object
onClick?: (event: MouseEvent | KeyboardEvent) => void
onClick?: (event: MouseEvent) => void
preserveScroll?: boolean | ((props: PageProps) => boolean)
preserveState?: boolean | ((props: PageProps) => boolean) | null
replace?: boolean
Expand Down