implemented the bloC design pattern issue #2374 #3128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iluwatar can you please review my pr? |
iluwatar
requested changes
Jan 11, 2025
PR SummaryThis PR implements the Bloc design pattern in Java. It separates UI components from state logic, improving maintainability and testability. The Bloc manages the application's state and notifies listeners of changes, allowing for dynamic updates to the UI. The implementation includes a Changes
autogenerated by presubmit.ai |
![github-actions[bot]](/~https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (15)
- 262a03c: Merge pull request Replaced occurrences of "bold" with "bald" #2 from darkhyper24/bloC-issue
Bloc issue
- fb6132c: chsnged state class to record
- 6761a9f: fixed renaming problem and added context to main
- e0f4cab: added pom.xml plugins and properties and fixed readme.md
- b4c862a: Merge pull request Update creating mechanism. #1 from darkhyper24/bloC-issue
separating ui from main file and adding more tests
- 9d33b16: separating ui from main file and adding more tests
- 60cd40e: Merge branch 'master' into master
- 9ea484e: Merge remote-tracking branch 'origin/master'
- 929eafb: fixed a test in MainTest file
- 9ec0a0c: Merge branch 'master' into master
- ee39a5c: added tests for the ui
- 2c042a3: fixed checkstyle warnings
- ede5f1d: added Readme file
- 826a067: added bloC design pattern
- 3a665b9: added bloC design pattern
Files Processed (14)
- bloc/Readme.md (1 hunk)
- bloc/etc/bloc.png (0 hunks)
- bloc/etc/bloc.puml (1 hunk)
- bloc/pom.xml (1 hunk)
- bloc/src/main/java/com/iluwatar/bloc/Bloc.java (1 hunk)
- bloc/src/main/java/com/iluwatar/bloc/BlocUi.java (1 hunk)
- bloc/src/main/java/com/iluwatar/bloc/ListenerManager.java (1 hunk)
- bloc/src/main/java/com/iluwatar/bloc/Main.java (1 hunk)
- bloc/src/main/java/com/iluwatar/bloc/State.java (1 hunk)
- bloc/src/main/java/com/iluwatar/bloc/StateListener.java (1 hunk)
- bloc/src/test/java/com/iluwatar/bloc/BlocTest.java (1 hunk)
- bloc/src/test/java/com/iluwatar/bloc/BlocUiTest.java (1 hunk)
- bloc/src/test/java/com/iluwatar/bloc/MainTest.java (1 hunk)
- pom.xml (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (3)
- 939e2f1: Merge pull request Model-View-Presenter pattern #3 from darkhyper24/bloC-issue
fixed conflicts
Files Processed (14)
- bloc/Readme.md (1 hunk)
- bloc/etc/bloc.png (0 hunks)
- bloc/etc/bloc.puml (1 hunk)
- bloc/pom.xml (1 hunk)
- bloc/src/main/java/com/iluwatar/bloc/Bloc.java (1 hunk)
- bloc/src/main/java/com/iluwatar/bloc/BlocUi.java (1 hunk)
- bloc/src/main/java/com/iluwatar/bloc/ListenerManager.java (1 hunk)
- bloc/src/main/java/com/iluwatar/bloc/Main.java (1 hunk)
- bloc/src/main/java/com/iluwatar/bloc/State.java (1 hunk)
- bloc/src/main/java/com/iluwatar/bloc/StateListener.java (1 hunk)
- bloc/src/test/java/com/iluwatar/bloc/BlocTest.java (1 hunk)
- bloc/src/test/java/com/iluwatar/bloc/BlocUiTest.java (1 hunk)
- bloc/src/test/java/com/iluwatar/bloc/MainTest.java (1 hunk)
- pom.xml (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
Revert "fixed conflicts"
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (2)
- b4f8262: Merge pull request Practical explanations #4 from darkhyper24/revert-3-bloC-issue
Revert "fixed conflicts"
- 2e1e34a: Revert "fixed conflicts"
Files Processed (0)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 502221b: restored files
Files Processed (14)
- bloc/Readme.md (1 hunk)
- bloc/etc/bloc.png (0 hunks)
- bloc/etc/bloc.puml (1 hunk)
- bloc/pom.xml (1 hunk)
- bloc/src/main/java/com/iluwatar/bloc/Bloc.java (1 hunk)
- bloc/src/main/java/com/iluwatar/bloc/BlocUi.java (1 hunk)
- bloc/src/main/java/com/iluwatar/bloc/ListenerManager.java (1 hunk)
- bloc/src/main/java/com/iluwatar/bloc/Main.java (1 hunk)
- bloc/src/main/java/com/iluwatar/bloc/State.java (1 hunk)
- bloc/src/main/java/com/iluwatar/bloc/StateListener.java (1 hunk)
- bloc/src/test/java/com/iluwatar/bloc/BlocTest.java (1 hunk)
- bloc/src/test/java/com/iluwatar/bloc/BlocUiTest.java (1 hunk)
- bloc/src/test/java/com/iluwatar/bloc/MainTest.java (1 hunk)
- pom.xml (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
|
sorry for the force pushing i had problems with outdated branches and had to recreate the module and delete the previous commits |
iluwatar
requested changes
Jan 15, 2025
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- b5f2551: renamed readme file and abstracted pom file
Files Processed (2)
- bloc/README.md (1 hunk)
- bloc/pom.xml (1 hunk)
Actionable Comments (0)
Skipped Comments (1)
-
bloc/README.md [83-125]
maintainability: "Improve
Blocclass design by separating concerns."
|
iluwatar
approved these changes
Jan 16, 2025
|
Looks good! Thank you for the contribution 🎉 @all-contributors please add @darkhyper24 for code |
|
I've put up a pull request to add @darkhyper24! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
this PR implements the bloc design pattern which is a design pattern used to separate the UI components in dart and flutter from the states logic making the code more maintainable and testable by following these steps:
Close BLoC design pattern #2374