Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose chain-registry structs (backport #4472) #4473

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 16, 2025

This PR exposes the chain registry structs that were recently added.
This package will then be used by Ignite Connect app to avoid duplication (ignite/apps#102)


This is an automatic backport of pull request #4472 done by Mergify.

* feat: expose chain-registry structs

* updates

* split

* structure

* updates

* lint

(cherry picked from commit ec26e2e)

# Conflicts:
#	ignite/services/scaffolder/chain_registry.go
@mergify mergify bot requested a review from ilgooz as a code owner January 16, 2025 06:36
@mergify mergify bot added the conflicts label Jan 16, 2025
Copy link
Contributor Author

mergify bot commented Jan 16, 2025

Cherry-pick of ec26e2e has failed:

On branch mergify/bp/release/v28.x.y/pr-4472
Your branch is up to date with 'origin/release/v28.x.y'.

You are currently cherry-picking commit ec26e2ee.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   ignite/pkg/chainregistry/asset.go
	new file:   ignite/pkg/chainregistry/chain.go
	new file:   ignite/pkg/chainregistry/consts.go
	new file:   ignite/pkg/chainregistry/doc.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   ignite/services/scaffolder/chain_registry.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs type:services Service-related issues. component:packages labels Jan 16, 2025
@julienrbrt julienrbrt self-assigned this Jan 16, 2025
@julienrbrt julienrbrt added skip-changelog Don't check changelog for new entries and removed conflicts labels Jan 16, 2025
@julienrbrt julienrbrt merged commit fcf01a4 into release/v28.x.y Jan 16, 2025
42 of 46 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v28.x.y/pr-4472 branch January 16, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ci CI/CD workflow and automated jobs. component:configs component:packages skip-changelog Don't check changelog for new entries type:services Service-related issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant