fix: fix app update command and duplicated apps (backport #3931)

changelog.md

@@ -17,6 +17,7 @@
 ### Bug Fixes
 
 - [#3905](/~https://github.com/ignite/cli/pull/3905) Fix `ignite completion`
+- [#3931](/~https://github.com/ignite/cli/pull/3931) Fix `app update` command and duplicated apps 
 
 ## [`v28.1.1`](/~https://github.com/ignite/cli/releases/tag/v28.1.1)
 

ignite/cmd/cmd.go

@@ -86,10 +86,14 @@
 	c.AddCommand(deprecated()...)
 
 	// Load plugins if any
-	if err := LoadPlugins(ctx, c); err != nil {
+	session := cliui.New(cliui.WithStdout(os.Stdout))
+	if err := LoadPlugins(ctx, c, session); err != nil {
 		return nil, nil, errors.Errorf("error while loading apps: %w", err)
 	}
-	return c, UnloadPlugins, nil
+	return c, func() {
+		UnloadPlugins()
+		session.End()
+	}, nil
 }
 
 func getVerbosity(cmd *cobra.Command) uilog.Verbosity {

ignite/cmd/plugin.go

@@ -31,7 +31,7 @@
 
 // LoadPlugins tries to load all the plugins found in configurations.
 // If no configurations found, it returns w/o error.
-func LoadPlugins(ctx context.Context, cmd *cobra.Command) error {
+func LoadPlugins(ctx context.Context, cmd *cobra.Command, session *cliui.Session) error {
 	var (
 		rootCmd        = cmd.Root()
 		pluginsConfigs []pluginsconfig.Plugin
@@ -53,9 +53,6 @@
 		return nil
 	}
 
-	session := cliui.New(cliui.WithStdout(os.Stdout))
-	defer session.End()
-
 	uniquePlugins := pluginsconfig.RemoveDuplicates(pluginsConfigs)
 	plugins, err = plugin.Load(ctx, uniquePlugins, plugin.CollectEvents(session.EventBus()))
 	if err != nil {
@@ -427,21 +424,17 @@
 		RunE: func(cmd *cobra.Command, args []string) error {
 			if len(args) == 0 {
 				// update all plugins
-				err := plugin.Update(plugins...)
-				if err != nil {
+				if err := plugin.Update(plugins...); err != nil {
 					return err
 				}
-				cmd.Println("All apps updated.")
 				return nil
 			}
 			// find the plugin to update
 			for _, p := range plugins {
-				if p.Path == args[0] {
-					err := plugin.Update(p)
-					if err != nil {
+				if p.HasPath(args[0]) {
+					if err := plugin.Update(p); err != nil {
 						return err
 					}
-					cmd.Printf("App %q updated.\n", p.Path)
 					return nil
 				}
 			}
@@ -479,7 +472,7 @@
 			}
 
 			for _, p := range conf.Apps {
-				if p.Path == args[0] {
+				if p.HasPath(args[0]) {
 					return errors.Errorf("app %s is already installed", args[0])
 				}
 			}
@@ -507,7 +500,6 @@
 				p.With[kv[0]] = kv[1]
 			}
 
-			session.StartSpinner("Loading app")
 			plugins, err := plugin.Load(cmd.Context(), []pluginsconfig.Plugin{p}, pluginsOptions...)
 			if err != nil {
 				return err
@@ -562,7 +554,7 @@
 
 			removed := false
 			for i, cp := range conf.Apps {
-				if cp.Path == args[0] {
+				if cp.HasPath(args[0]) {
 					conf.Apps = append(conf.Apps[:i], conf.Apps[i+1:]...)
 					removed = true
 					break
@@ -648,7 +640,7 @@
 			ctx := cmd.Context()
 
 			for _, p := range plugins {
-				if p.Path == args[0] {
+				if p.HasPath(args[0]) {
 					manifest, err := p.Interface.Manifest(ctx)
 					if err != nil {
 						return errors.Errorf("error while loading app manifest: %w", err)