Skip to content

Commit

Permalink
fix(chain): fix issue in release ci and command (#4474)
Browse files Browse the repository at this point in the history
* fix(chain): fix issue in release ci and command

* updates
  • Loading branch information
julienrbrt authored Jan 17, 2025
1 parent ec26e2e commit a0ac845
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 1 deletion.
1 change: 1 addition & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
- [#4091](/~https://github.com/ignite/cli/pull/4091) Fix race conditions in the plugin logic
- [#4128](/~https://github.com/ignite/cli/pull/4128) Check for duplicate proto fields in config
- [#4402](/~https://github.com/ignite/cli/pull/4402) Fix gentx parser into the cosmosutil package
- [#4474](/~https://github.com/ignite/cli/pull/4474) Fix issue in `build --release` command

## [`v28.7.0`](/~https://github.com/ignite/cli/releases/tag/v28.7.0)

Expand Down
13 changes: 13 additions & 0 deletions ignite/pkg/archive/tar_gz.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,19 @@ func addToArchive(tw *tar.Writer, filename string) error {
}

// Create a tar Header from the FileInfo data
if info.IsDir() {
hdr, err := tar.FileInfoHeader(info, info.Name())
if err != nil {
return err
}
hdr.Name = filename
if err := tw.WriteHeader(hdr); err != nil {
return err
}

return nil
}

header, err := tar.FileInfoHeader(info, info.Name())
if err != nil {
return err
Expand Down
2 changes: 1 addition & 1 deletion ignite/services/chain/build.go
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ func (c *Chain) BuildRelease(
defer tarf.Close()

if err := archive.CreateArchive(out, tarf); err != nil {
return "", err
return "", errors.Errorf("error creating release archive: %w", err)
}
}

Expand Down
1 change: 1 addition & 0 deletions ignite/templates/app/files/.github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ jobs:
args: chain build --release --release.prefix ${{ steps.vars.outputs.tarball_prefix }} -t linux:amd64 -t darwin:amd64 -t darwin:arm64 -y
env:
DO_NOT_TRACK: 1
GOFLAGS: "-buildvcs=false"

- name: Delete the "latest" Release
uses: dev-drprasad/delete-tag-and-release@v0.2.1
Expand Down

0 comments on commit a0ac845

Please sign in to comment.