feat: Allow Unicode characters everywhere #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesara
changed the title
rjsparks
approved these changes
Jul 28, 2023
kesara
added a commit
to kesara/xml2rfc
that referenced
this pull request
Feb 19, 2024
PR ietf-tools#1017 allowed Unicord characters everywhere. This fixes a bug that xml2rfc was gurding in againts non-ASCII characters in attribute values. With `--warn-bare-unicode`, xml2rfc will warn if non-ASCII characters are present in attribute values. Fixes ietf-tools#1105
kesara
added a commit
to kesara/xml2rfc
that referenced
this pull request
Feb 19, 2024
PR ietf-tools#1017 allowed Unicord characters everywhere. This fixes a bug that xml2rfc was guarding against non-ASCII characters in attribute values. With `--warn-bare-unicode`, xml2rfc will warn if non-ASCII characters are present in attribute values. Fixes ietf-tools#1105
kesara
added a commit
to kesara/xml2rfc
that referenced
this pull request
Feb 20, 2024
PR ietf-tools#1017 allowed Unicord characters everywhere. This fixes a bug that xml2rfc was guarding against non-ASCII characters in attribute values. With `--warn-bare-unicode`, xml2rfc will warn if non-ASCII characters are present in attribute values. Fixes ietf-tools#1105
kesara
added a commit
to kesara/xml2rfc
that referenced
this pull request
Feb 20, 2024
PR ietf-tools#1017 allowed Unicord characters everywhere. This fixes a bug that xml2rfc was guarding against non-ASCII characters in attribute values. With `--warn-bare-unicode`, xml2rfc will warn if non-ASCII characters are present in attribute values. Fixes ietf-tools#1105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR that does the following:
--warn-bare-unicodecommand line option,xml2rfcwill warn if Unicode characters are present in any element that traditionally Unicode content is not allowed.Traditionally, Unicode content is allowed in the following elements:
artwork,city,cityarea,code,country,email,extaddr,organization,pobox,postalLine,refcontent,region,sortingcode,sourcecode,street,title,u.With #895 bare use of Unicode characters is added to the
telement. But it's implemented in such a way that--warn-bare-unicodewarns about it. This PR will keep that warning.Fixes #960.